Check connection in save file change (#1454)

* check connection in save file change

* fix unit tests

Author: Hitenjain14

code/go/0chain.net/blobbercore/allocation/allocationchange.go

@@ -174,10 +174,11 @@ func GetAllocationChanges(ctx context.Context, connectionID, allocationID, clien
 func GetConnectionObj(ctx context.Context, connectionID, allocationID, clientID string) (*AllocationChangeCollector, error) {
 	cc := &AllocationChangeCollector{}
 	db := datastore.GetStore().GetTransaction(ctx)
-	err := db.Where("id = ? and allocation_id = ? and client_id = ?",
+	err := db.Where("id = ? and allocation_id = ? and client_id = ? AND status <> ?",
 		connectionID,
 		allocationID,
 		clientID,
+		DeletedConnection,
 	).Take(cc).Error
 
 	if err == nil {
@@ -189,7 +190,7 @@ func GetConnectionObj(ctx context.Context, connectionID, allocationID, clientID
 		cc.AllocationID = allocationID
 		cc.ClientID = clientID
 		cc.Status = NewConnection
-		err = cc.Create(ctx)
+		err = cc.Save(ctx)
 		if err != nil {
 			return nil, err
 		}

code/go/0chain.net/blobbercore/allocation/connection.go

@@ -15,7 +15,7 @@ import (
 
 var (
 	// ConnectionObjCleanInterval start to clean the connectionObjMap
-	ConnectionObjCleanInterval = 10 * time.Minute
+	ConnectionObjCleanInterval = 45 * time.Minute
 	// ConnectionObjTimout after which connectionObj entry should be invalid
 	ConnectionObjTimeout = 30 * time.Minute
 )
@@ -182,7 +182,11 @@ func SaveFileChange(ctx context.Context, connectionID, pathHash, fileName string
 		change.lock.Lock()
 		defer change.lock.Unlock()
 		connectionObj.lock.Unlock()
-		err := cmd.AddChange(ctx)
+		_, err := GetConnectionObj(ctx, connectionID, connectionObj.AllocationID, connectionObj.ClientID)
+		if err != nil {
+			return saveChange, err
+		}
+		err = cmd.AddChange(ctx)
 		if err != nil {
 			return saveChange, err
 		}

code/go/0chain.net/blobbercore/handler/handler_test.go

@@ -847,6 +847,12 @@ func TestHandlers_Requiring_Signature(t *testing.T) {
 						sqlmock.NewRows([]string{"found"}).
 							AddRow(false),
 					)
+				mock.ExpectQuery(regexp.QuoteMeta(`SELECT * FROM "allocation_connections" WHERE`)).
+					WithArgs(connectionID, alloc.ID, alloc.OwnerID, allocation.DeletedConnection).
+					WillReturnRows(
+						sqlmock.NewRows([]string{"id", "allocation_id", "client_id"}).
+							AddRow("connection_id", alloc.ID, alloc.OwnerID),
+					)
 				mock.ExpectQuery(regexp.QuoteMeta(`INSERT INTO "allocation_changes"`)).
 					WithArgs(aa, aa, aa, aa, aa, aa, aa).
 					WillReturnRows(

code/go/0chain.net/blobbercore/handler/object_operation_handler.go

@@ -1206,9 +1206,6 @@ func (fsh *StorageHandler) CreateDir(ctx context.Context, r *http.Request) (*all
 	newDir.AllocationID = allocationID
 
 	connectionObj.AddChange(allocationChange, &newDir)
-	if err != nil {
-		return nil, err
-	}
 
 	err = connectionObj.Save(ctx)
 	if err != nil {

code/go/0chain.net/blobbercore/handler/worker.go

@@ -101,6 +101,7 @@ func cleanupTempFiles(ctx context.Context) {
 				ndb.Unscoped().Delete(c)
 			}
 			ndb.Unscoped().Delete(connection)
+			allocation.DeleteConnectionObjEntry(connection.ID)
 		}
 
 		ndb.Commit()