Fix wrong usage of id attribute for the close button

Simone Primarosa · Simone Primarosa · commit fac8c434a78c · 2017-01-21T01:58:45.000+01:00
diff --git a/lib/angular-tooltips.js b/lib/angular-tooltips.js
@@ -703,9 +703,6 @@
               }
 
               tipTipElement.replaceWith($compile(tipTipElement)(newScope));
-              /*eslint-disable no-use-before-define*/
-              unregisterOnTooltipControllerChange();
-              /*eslint-enable no-use-before-define*/
             }
           }
           , onTooltipSizeChange = function onTooltipSizeChange(newValue) {
@@ -746,9 +743,7 @@
           , unregisterOnTooltipSpeedChange = $attrs.$observe('tooltipSpeed', onTooltipSpeedChange)
           , unregisterTipContentChangeWatcher = scope.$watch(whenActivateMultilineCalculation, calculateIfMultiLine);
 
-        closeButtonElement.attr({
-          'id': 'close-button'
-        });
+        closeButtonElement.addClass('close-button');
         closeButtonElement.html('&times;');
 
         tipElement.addClass('_hidden');
diff --git a/lib/angular-tooltips.scss b/lib/angular-tooltips.scss
@@ -255,7 +255,7 @@ tooltip {
 
 tip-tip {
 
-  #close-button {
+  .close-button {
     cursor: pointer;
     float: right;
     left: 8%;

Original file line number	Diff line number	Diff line change
`@@ -703,9 +703,6 @@`
`703`	`703`	`}`
`704`	`704`
`705`	`705`	`tipTipElement.replaceWith($compile(tipTipElement)(newScope));`
`706`		`- /eslint-disable no-use-before-define/`
`707`		`- unregisterOnTooltipControllerChange();`
`708`		`- /eslint-enable no-use-before-define/`
`709`	`706`	`}`
`710`	`707`	`}`
`711`	`708`	`, onTooltipSizeChange = function onTooltipSizeChange(newValue) {`
`@@ -746,9 +743,7 @@`
`746`	`743`	`, unregisterOnTooltipSpeedChange = $attrs.$observe('tooltipSpeed', onTooltipSpeedChange)`
`747`	`744`	`, unregisterTipContentChangeWatcher = scope.$watch(whenActivateMultilineCalculation, calculateIfMultiLine);`
`748`	`745`
`749`		`- closeButtonElement.attr({`
`750`		`- 'id': 'close-button'`
`751`		`- });`
	`746`	`+ closeButtonElement.addClass('close-button');`
`752`	`747`	`closeButtonElement.html('×');`
`753`	`748`
`754`	`749`	`tipElement.addClass('_hidden');`