Adding unordered lists to be parsed. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ActuallyTaylor
left a comment
ActuallyTaylor
left a comment
There was a problem hiding this comment.
This looks really good! The only note that I have is the case naming for all the functions.
| final class BasicHTMLTests { | ||
|
|
||
| func testAll() throws { | ||
| @Test func All() throws { |
Owner
There was a problem hiding this comment.
Suggested change
| @Test func All() throws { | |
| @Test func all() throws { |
| } | ||
|
|
||
| func testHeaderLevelOne() throws { | ||
| @Test func HeaderLevelOne() throws { |
Owner
There was a problem hiding this comment.
Suggested change
| @Test func HeaderLevelOne() throws { | |
| @Test func headerLevelOne() throws { |
| } | ||
|
|
||
| func testHeaderLevelTwo() throws { | ||
| @Test func HeaderLevelTwo() throws { |
Owner
There was a problem hiding this comment.
Suggested change
| @Test func HeaderLevelTwo() throws { | |
| @Test func headerLevelTwo() throws { |
| } | ||
|
|
||
| func testHeaderLevelThree() throws { | ||
| @Test func HeaderLevelThree() throws { |
Owner
There was a problem hiding this comment.
Suggested change
| @Test func HeaderLevelThree() throws { | |
| @Test func headerLevelThree() throws { |
| } | ||
|
|
||
| func testHeaderLevelFour() throws { | ||
| @Test func HeaderLevelFour() throws { |
Owner
There was a problem hiding this comment.
Suggested change
| @Test func HeaderLevelFour() throws { | |
| @Test func headerLevelFour() throws { |
| } | ||
|
|
||
| func testItalicizedBoldText() throws { | ||
| @Test func ItalicizedBoldText() throws { |
Owner
There was a problem hiding this comment.
Suggested change
| @Test func ItalicizedBoldText() throws { | |
| @Test func italicizedBoldText() throws { |
| } | ||
|
|
||
| func testFencedCodeBlockWithLanguage() throws { | ||
| @Test func FencedCodeBlockWithLanguage() throws { |
Owner
There was a problem hiding this comment.
Suggested change
| @Test func FencedCodeBlockWithLanguage() throws { | |
| @Test func fencedCodeBlockWithLanguage() throws { |
| } | ||
|
|
||
| func testFencedCodeBlockWithoutLanguage() throws { | ||
| @Test func FencedCodeBlockWithoutLanguage() throws { |
Owner
There was a problem hiding this comment.
Suggested change
| @Test func FencedCodeBlockWithoutLanguage() throws { | |
| @Test func fencedCodeBlockWithoutLanguage() throws { |
| } | ||
|
|
||
| func testCode() throws { | ||
| @Test func Code() throws { |
Owner
There was a problem hiding this comment.
Suggested change
| @Test func Code() throws { | |
| @Test func code() throws { |
| #expect(markdown == correctOutput) | ||
| } | ||
|
|
||
| @Test func UnorderedLists() throws { |
Owner
There was a problem hiding this comment.
Suggested change
| @Test func UnorderedLists() throws { | |
| @Test func unorderedLists() throws { |
Author
|
Tnx for your feedback. I did a simple replace and forgot to lowercase the first letter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was missing this for my own implementation. Maybe handy for someone else.
I've updated the tests to use Swift Testing.