-
Notifications
You must be signed in to change notification settings - Fork 277
AAE-27107 Improve repeatable section widget #11336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AAE-27107 Improve repeatable section widget #11336
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the repeatable section functionality in forms, renaming newRowsLimit to maxNumberOfRows for clarity and adding read-only state support for repeatable sections. The changes improve the UI/UX by repositioning the delete button and adding tooltips.
Key changes:
- Parameter renamed from
newRowsLimittomaxNumberOfRowsthroughout the codebase - Added read-only state handling for repeatable sections and their child fields
- Refactored value update logic by extracting
getFormValue()method - Repositioned delete row button in the UI with improved styling and tooltip support
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/core/src/lib/i18n/en.json | Added translation key for "Delete row" tooltip |
| lib/core/src/lib/form/components/widgets/repeat/repeat.widget.spec.ts | Updated parameter names and test values; removed obsolete getAddedRowsCount tests |
| lib/core/src/lib/form/components/widgets/repeat/repeat.widget.scss | Removed collapsible cursor styles; added readonly state styling |
| lib/core/src/lib/form/components/widgets/repeat/repeat.widget.html | Updated to use maxNumberOfRows and element.field.rows.length; added disabled state support |
| lib/core/src/lib/form/components/widgets/core/form-field.model.ts | Major refactoring: renamed parameter, added read-only state propagation, extracted getFormValue(), updated unique ID generation |
| lib/core/src/lib/form/components/widgets/core/form-field.model.spec.ts | Added comprehensive tests for disabled state behavior in repeatable sections |
| lib/core/src/lib/form/components/form-renderer.component.ts | Added MatTooltipModule import |
| lib/core/src/lib/form/components/form-renderer.component.spec.ts | Updated CSS selectors to match new button class names |
| lib/core/src/lib/form/components/form-renderer.component.scss | Updated styles for repositioned delete button and disabled state |
| lib/core/src/lib/form/components/form-renderer.component.html | Repositioned delete button with tooltip and disabled state support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lib/core/src/lib/form/components/widgets/core/form-field.model.ts
Outdated
Show resolved
Hide resolved
31b6c1a to
b764575
Compare
b764575 to
5c163db
Compare
|



Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Improvements:
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: