Update CustomerController.cs

Author: Amitpnk

OA/OA/Controllers/CustomerController.cs

@@ -29,9 +29,7 @@ public CustomerController(IMapper mapper, ICustomerService customerService, ICus
         [HttpGet]
         public async Task<ActionResult> Get()
         {
-
             var result = await _customerRepository.GetAllCustomersAsync();
-
             var mappedResult = _mapper.Map<IEnumerable<Customer>>(result);
             return Ok(mappedResult);
         }
@@ -42,55 +40,39 @@ public async Task<ActionResult> Get()
         [Route("{customerName}", Name = "GetCustomer")]
         public async Task<ActionResult> Get(string customerName, bool includeOrders = false)
         {
-            try
-            {
-                var result = await _customerRepository.GetCustomerAsync(customerName, includeOrders);
-
-                if (result == null)
-                {
-                    return NotFound();
-                }
-                return Ok(_mapper.Map<CustomerModel>(result));
-            }
-            catch (Exception ex)
+            var result = await _customerRepository.GetCustomerAsync(customerName, includeOrders);
+            if (result == null)
             {
-                // TODO Add logging
-                return StatusCode(StatusCodes.Status500InternalServerError, ex.Message);
+                return NotFound();
             }
+            return Ok(_mapper.Map<CustomerModel>(result));
         }
 
         [Route("")]
         [HttpPost]
         public async Task<ActionResult<CustomerModel>> Post([FromBody] CustomerModel model)
         {
-            try
+
+            if (await _customerRepository.GetCustomerAsync(model.CustomerName) != null)
             {
-                if (await _customerRepository.GetCustomerAsync(model.CustomerName) != null)
-                {
-                    ModelState.AddModelError("CustomerName", "Customer Name in use");
-                }
+                ModelState.AddModelError("CustomerName", "Customer Name in use");
+            }
 
-                if (ModelState.IsValid)
-                {
-                    var customer = _mapper.Map<Customer>(model);
+            if (ModelState.IsValid)
+            {
+                var customer = _mapper.Map<Customer>(model);
 
-                    _customerService.AddCustomer(customer);
+                _customerService.AddCustomer(customer);
 
-                    if (_customerService.SaveChangesAsync())
-                    {
-                        // Get the inserted CustomerModel 
-                        var newModel = _mapper.Map<CustomerModel>(customer);
+                if (_customerService.SaveChangesAsync())
+                {
+                    // Get the inserted CustomerModel 
+                    var newModel = _mapper.Map<CustomerModel>(customer);
 
-                        return CreatedAtRoute("GetCustomer",
-                            new { newModel.CustomerName }, newModel);
-                    }
+                    return CreatedAtRoute("GetCustomer",
+                        new { newModel.CustomerName }, newModel);
                 }
             }
-            catch (Exception ex)
-            {
-                // TODO Add logging
-                return StatusCode(StatusCodes.Status500InternalServerError, ex.Message);
-            }
             return BadRequest(ModelState);
         }