Skip to content

Commit 07f344a

Browse files
committed
fix: update test method signatures to include ignored parameter for consistency
1 parent cade32e commit 07f344a

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

tests/Feature/Comment/CollectionTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ private function getJsonResult(Collection $comments, ?array $attributes = null,
8383
))
8484
->reduce(fn(Collection $all, Collection $value) => $all->merge($value), collect());
8585

86-
$isLaravel12 = ((int)explode('.', Application::VERSION, 2)) >= 12;
86+
$isLaravel12 = ((int)explode('.', Application::VERSION, 2)[0]) >= 12;
8787

8888
return collect(array_filter([
8989
'data' => $data,

tests/Unit/Descriptors/ValueTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ public static function modelsValues()
9191
* @dataProvider values
9292
*/
9393
#[DataProvider('values')]
94-
public function testConvertValue($class, $value, $excepted)
94+
public function testConvertValue($class, $value, $excepted, $_ignored)
9595
{
9696
/** @var \Ark4ne\JsonApi\Descriptors\Values\Value $v */
9797
$v = new $class(null);
@@ -102,7 +102,7 @@ public function testConvertValue($class, $value, $excepted)
102102
* @dataProvider modelsValues
103103
*/
104104
#[DataProvider('modelsValues')]
105-
public function testValueFor($model, $class, $value, $excepted)
105+
public function testValueFor($model, $class, $value, $excepted, $_ignored)
106106
{
107107
data_set($model, 'attr', $value);
108108

@@ -118,7 +118,7 @@ public function testValueFor($model, $class, $value, $excepted)
118118
* @dataProvider modelsValues
119119
*/
120120
#[DataProvider('modelsValues')]
121-
public function testValueForWithNull($model, $class, $value, $excepted)
121+
public function testValueForWithNull($model, $class, $value, $excepted, $_ignored)
122122
{
123123
data_set($model, 'attr', null);
124124

tests/Unit/Support/ValuesTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ public static function dataAttribute()
136136
* @dataProvider dataAttribute
137137
*/
138138
#[DataProvider('dataAttribute')]
139-
public function testHasAttribute($data, $attribute, $expected)
139+
public function testHasAttribute($data, $attribute, $expected, $_ignored)
140140
{
141141
$this->assertEquals($expected, Values::hasAttribute($data, $attribute));
142142
}

0 commit comments

Comments
 (0)