test: improve unit concerns\relationships

Author: Ark4ne

tests/Support/Reflect.php

@@ -2,15 +2,25 @@
 
 namespace Test\Support;
 
+use ReflectionClass;
+
 class Reflect
 {
     public static function invoke($object, string $method, ...$args)
     {
-        $reflect = new \ReflectionClass($object);
+        $reflect = new ReflectionClass($object);
         $reflectMethod = $reflect->getMethod($method);
         $reflectMethod->setAccessible(true);
 
         return $reflectMethod->invoke($object, ...$args);
     }
 
+    public static function set($object, string $property, $value)
+    {
+        $reflect = new ReflectionClass($object);
+        $reflectProperty = $reflect->getProperty($property);
+        $reflectProperty->setAccessible(true);
+
+        $reflectProperty->setValue($object, $value);
+    }
 }

tests/Unit/Concerns/RelationshipsTest.php

@@ -6,20 +6,21 @@
 use Ark4ne\JsonApi\Resource\Relationship;
 use Ark4ne\JsonApi\Resource\Resourceable;
 use Ark4ne\JsonApi\Resource\Support\Includes;
+use Illuminate\Database\Eloquent\Model;
 use Illuminate\Http\Request;
 use Illuminate\Http\Resources\Json\JsonResource;
 use Test\Support\Reflect;
 use Test\TestCase;
 
 class RelationshipsTest extends TestCase
 {
-    public function testMapRelationship()
+    public function testMapRelationshipMinimal()
     {
         $stub = new class(null) extends JsonResource {
             use Relationships;
         };
 
-        $minimal = false;
+        $minimal = true;
         $request = new Request();
         $relationship = $this->createMock(Relationship::class);
         $relationship
@@ -32,16 +33,6 @@ public function testMapRelationship()
                     'links' => ['self' => "://api.com/child/abc-123"],
                     'meta' => ['total' => 1],
                 ],
-                'with' => [
-                    'with-some' => 'some-value'
-                ],
-                'included' => [
-                    [
-                        'id' => 'abc-123',
-                        'type' => 'child',
-                        'foo' => 'bar'
-                    ]
-                ],
             ]);
 
         $actual = Reflect::invoke($stub, 'mapRelationship', $minimal, $request, $relationship);
@@ -51,22 +42,17 @@ public function testMapRelationship()
             'links' => ['self' => "://api.com/child/abc-123"],
             'meta' => ['total' => 1],
         ], $actual);
-        $this->assertEquals([
-            'with-some' => ['some-value'],
-            'included' => [
-                [
-                    'id' => 'abc-123',
-                    'type' => 'child',
-                    'foo' => 'bar'
-                ]
-            ]
-        ], $stub->with($request));
 
+        $this->assertEquals([], $stub->with($request));
+    }
+
+    public function testMapRelationshipFull()
+    {
         $stub = new class(null) extends JsonResource {
             use Relationships;
         };
 
-        $minimal = true;
+        $minimal = false;
         $request = new Request();
         $relationship = $this->createMock(Relationship::class);
         $relationship
@@ -79,6 +65,16 @@ public function testMapRelationship()
                     'links' => ['self' => "://api.com/child/abc-123"],
                     'meta' => ['total' => 1],
                 ],
+                'with' => [
+                    'with-some' => 'some-value'
+                ],
+                'included' => [
+                    [
+                        'id' => 'abc-123',
+                        'type' => 'child',
+                        'foo' => 'bar'
+                    ]
+                ],
             ]);
 
         $actual = Reflect::invoke($stub, 'mapRelationship', $minimal, $request, $relationship);
@@ -88,11 +84,32 @@ public function testMapRelationship()
             'links' => ['self' => "://api.com/child/abc-123"],
             'meta' => ['total' => 1],
         ], $actual);
+        $this->assertEquals([
+            'with-some' => ['some-value'],
+            'included' => [
+                [
+                    'id' => 'abc-123',
+                    'type' => 'child',
+                    'foo' => 'bar'
+                ]
+            ]
+        ], $stub->with($request));
+    }
 
-        $this->assertEquals([], $stub->with($request));
+    public function testRequestedRelationshipsNoRelations()
+    {
+        Includes::flush();
+        $resource = new class(collect()) extends JsonResource {
+            use Relationships;
+        };
+
+        $actual = Reflect::invoke($resource, 'requestedRelationships', new Request());
+
+        $this->assertEquals([], $actual);
+        $this->assertEquals([], $resource->with);
     }
 
-    public function testRequestedRelationships()
+    public function testRequestedRelationshipsNoInclude()
     {
         Includes::flush();
         $stub = $this->getStub();
@@ -109,7 +126,10 @@ public function testRequestedRelationships()
             ],
         ], $actual);
         $this->assertEquals([], $stub->with);
+    }
 
+    public function testRequestedRelationshipsOneDepthInclude()
+    {
         Includes::flush();
         $stub = $this->getStub();
 
@@ -144,7 +164,10 @@ public function testRequestedRelationships()
                 ]
             ]
         ], $stub->with);
+    }
 
+    public function testRequestedRelationshipsTwoDepthInclude()
+    {
         Includes::flush();
         $stub = $this->getStub();
 
@@ -195,6 +218,63 @@ public function testRequestedRelationships()
         ], $stub->with);
     }
 
+    public function testRequestedRelationshipsWithMissingValue()
+    {
+        $model = new class(['id' => 1]) extends Model {
+            protected $fillable = ['id'];
+        };
+
+        Reflect::set($model, 'relations', ['loadedRelation' => (object)['id' => 3]]);
+
+        $resource = new class($model) extends JsonResource {
+            use Relationships;
+
+            public function toRelationships(Request $request): iterable
+            {
+                return [
+                    'foo' => new class((object)['id' => 2]) extends JsonResource implements Resourceable {
+                        public function toArray($request, bool $minimal = false): array
+                        {
+                            return [
+                                'id' => $this->id,
+                                'type' => 'foo'
+                            ];
+                        }
+                    },
+                    'bar' => $this->when(false, fn() => JsonResource::make(collect())),
+                    'baz' => JsonResource::collection($this->whenLoaded('not-loaded-relation')),
+                    'tar' => new class($this->whenLoaded('loadedRelation')) extends JsonResource implements
+                        Resourceable {
+                        public function toArray($request, bool $minimal = false): array
+                        {
+                            return [
+                                'id' => $this->id,
+                                'type' => 'tar'
+                            ];
+                        }
+                    },
+                ];
+            }
+        };
+
+        $actual = Reflect::invoke($resource, 'requestedRelationships', new Request());
+
+        $this->assertEquals([
+            'foo' => [
+                'data' => [
+                    'id' => 2,
+                    'type' => 'foo'
+                ]
+            ],
+            'tar' => [
+                'data' => [
+                    'id' => 3,
+                    'type' => 'tar'
+                ]
+            ]
+        ], $actual);
+    }
+
     private function getStub()
     {
         return new class((object)[]) extends JsonResource implements Resourceable {