Skip to content

Commit a5ea664

Browse files
author
AutomatedOwl
committed
Updated TestNG listener to set iTestResult failure.
Updated selenium dependency version.
1 parent 29ee3c8 commit a5ea664

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

junit5/pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,17 +63,17 @@
6363
<dependency>
6464
<groupId>org.seleniumhq.selenium</groupId>
6565
<artifactId>selenium-api</artifactId>
66-
<version>3.8.1</version>
66+
<version>3.12.0</version>
6767
</dependency>
6868
<dependency>
6969
<groupId>org.seleniumhq.selenium</groupId>
7070
<artifactId>selenium-chrome-driver</artifactId>
71-
<version>3.8.1</version>
71+
<version>3.12.0</version>
7272
</dependency>
7373
<dependency>
7474
<groupId>org.seleniumhq.selenium</groupId>
7575
<artifactId>selenium-remote-driver</artifactId>
76-
<version>3.8.1</version>
76+
<version>3.12.0</version>
7777
</dependency>
7878
<dependency>
7979
<groupId>org.seleniumhq.selenium</groupId>

testng/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,12 @@
4848
<dependency>
4949
<groupId>org.seleniumhq.selenium</groupId>
5050
<artifactId>selenium-chrome-driver</artifactId>
51-
<version>3.8.1</version>
51+
<version>3.12.0</version>
5252
</dependency>
5353
<dependency>
5454
<groupId>org.seleniumhq.selenium</groupId>
5555
<artifactId>selenium-api</artifactId>
56-
<version>3.8.1</version>
56+
<version>3.12.0</version>
5757
</dependency>
5858
<dependency>
5959
<groupId>org.testng</groupId>

testng/src/main/java/com/github/automatedowl/tools/JSErrorsCollectorListener.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,8 @@ public void afterInvocation(IInvokedMethod iInvokedMethod, ITestResult iTestResu
6363
}
6464
else if (isAssertJSErrorsEnabled(
6565
iInvokedMethod) && getJSErrorsFromLogEntries(logEntries).anyMatch(e -> true)) {
66-
JSErrorsDriverHolder.getDriverForTest(iInvokedMethod.getTestMethod().getMethodName()).quit();
67-
throw new WebDriverException(JS_ERRORS_EXCEPTION_STRING);
66+
logger.severe(JS_ERRORS_EXCEPTION_STRING);
67+
iTestResult.setStatus(ITestResult.FAILURE);
6868
}
6969
}
7070
}

0 commit comments

Comments
 (0)