Merge pull request #134 from Axway-API-Management-Plus/fix-custom-prop-issue

Default the parent custom property

Author: Chris Wiechmann

apibuilder4elastic/custom_flow_nodes/api-builder-plugin-axway-api-management/src/customProperties.js

@@ -37,6 +37,10 @@ async function mergeCustomProperties(params, options) {
 		logger.info(`Custom properties are ignore for this template.`);
 		return options.setOutput('noUpdate', desiredIndexTemplate);
 	}
+	if (!customPropertiesSettings.parent) {
+		customPropertiesSettings.parent = ""; // Use no parent as default
+	}
+	
 	var updateRequired = false;
 	for (var prop in customProperties) {
 		if (Object.prototype.hasOwnProperty.call(customProperties, prop)) {

apibuilder4elastic/custom_flow_nodes/api-builder-plugin-axway-api-management/test/test-customProperties-MappingMerge.js

@@ -72,12 +72,12 @@ describe('Merge custom properties tests', () => {
 			expect(value.mappings.properties['customProperties.customProperty3'].type).to.equal('keyword');
 		});
 
-		it('should merge into indexMappingTemplate as custom properties are missing', async () => {
+		it('should merge into indexMappingTemplate as custom properties are missing and parent is not set', async () => {
 			const { value, output } = await flowNode.mergeCustomProperties({ 
 				customProperties: JSON.parse(fs.readFileSync('./test/testInput/customPropertiesConfig.json'), null), 
 				desiredIndexTemplate: JSON.parse(fs.readFileSync('./test/testInput/desiredIndexTemplate.json'), null),
 				actualIndexTemplate: JSON.parse(fs.readFileSync('./test/testInput/actualIndexTemplate.json'), null), 
-				customPropertiesSettings: { merge: true, parent: "" }
+				customPropertiesSettings: { merge: true }
 			});
 			expect(output).to.equal('next');
 			expect(value.mappings.properties['customProperties.customProperty1']).to.be.an('Object');