Skip to content

Commit 1a513e2

Browse files
authored
Fixed Page name displaying in admin top panel (#2749)
1 parent eac74c9 commit 1a513e2

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

src/admin/rightPanel.tsx

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -98,12 +98,20 @@ export class RightPanel extends React.Component<{}, RightPanelState> {
9898
componentDidMount(): void {
9999
this.eventManager.addEventListener('onDataChange', this.onDataChange.bind(this));
100100
window.addEventListener('resize', this.checkScreenSize.bind(this));
101+
this.router.addRouteChangeListener(() => this.getPageName());
102+
this.getPageName();
101103
this.checkScreenSize();
102104
this.getRoles();
103105
}
104106

105-
componentDidUpdate(prevProps: Readonly<{}>, prevState: Readonly<RightPanelState>, snapshot?: any): void {
106-
if (this.state.isFocusedState && !prevState.isFocusedState) {
107+
componentWillUnmount() {
108+
this.eventManager.removeEventListener('onDataChange', this.onDataChange.bind(this));
109+
window.removeEventListener('resize', this.checkScreenSize.bind(this));
110+
this.router.removeRouteChangeListener(() => this.getPageName());
111+
}
112+
113+
setPageName = () => {
114+
if (this.state.isFocusedState) {
107115
const host = this.viewManager.getHost();
108116
if (host.name === HostNames.Page) {
109117
this.getPageName();
@@ -115,11 +123,6 @@ export class RightPanel extends React.Component<{}, RightPanelState> {
115123
}
116124
}
117125

118-
componentWillUnmount() {
119-
this.eventManager.removeEventListener('onDataChange', this.onDataChange.bind(this));
120-
window.removeEventListener('resize', this.checkScreenSize.bind(this));
121-
}
122-
123126
getRoles = async (): Promise<void> => {
124127
const roles = await this.roleService.getRoles();
125128

0 commit comments

Comments
 (0)