Skip to content

Commit b7e8be8

Browse files
author
Karina Ranadive
committed
removed redundant basic lrp test
1 parent 4af974c commit b7e8be8

File tree

1 file changed

+14
-19
lines changed

1 file changed

+14
-19
lines changed

test/integration/lrp/lrp_test.go

Lines changed: 14 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -256,36 +256,31 @@ func testLRPLifecycle(t *testing.T, ctx context.Context, clientPod corev1.Pod, k
256256
config := kubernetes.MustGetRestConfig()
257257
cs := kubernetes.MustGetClientset()
258258

259-
// Step 1: Initial Basic LRP test to verify LRP is working
260-
t.Log("Step 1: Initial DNS test - verifying LRP functionality")
261-
testLRPCase(t, ctx, clientPod, []string{
262-
"nslookup", "google.com", kubeDNS,
263-
}, "", "", false, true, getPrometheusAddress(initialPrometheusPort))
264259

265-
// Step 2: Validate LRP using cilium commands
266-
t.Log("Step 2: Validating LRP using cilium commands")
260+
// Step 1: Validate LRP using cilium commands
261+
t.Log("Step 1: Validating LRP using cilium commands")
267262
validateCiliumLRP(t, ctx, cs, config)
268263

269-
// Step 3: Restart busybox pods and verify LRP still works
270-
t.Log("Step 3: Restarting client pods to test persistence")
264+
// Step 2: Restart busybox pods and verify LRP still works
265+
t.Log("Step 2: Restarting client pods to test persistence")
271266
restartedPod := restartClientPodsAndGetPod(t, ctx, cs, clientPod)
272267

273-
// Step 4: Verify metrics after restart
274-
t.Log("Step 4: Verifying LRP functionality after pod restart")
268+
// Step 3: Verify metrics after restart
269+
t.Log("Step 3: Verifying LRP functionality after pod restart")
275270
testLRPCase(t, ctx, restartedPod, []string{
276271
"nslookup", "google.com", kubeDNS,
277272
}, "", "", false, true, getPrometheusAddress(initialPrometheusPort))
278273

279-
// Step 5: Validate cilium commands still show LRP
280-
t.Log("Step 5: Re-validating cilium LRP after restart")
274+
// Step 4: Validate cilium commands still show LRP
275+
t.Log("Step 4: Re-validating cilium LRP after restart")
281276
validateCiliumLRP(t, ctx, cs, config)
282277

283-
// Step 6: Delete and recreate resources & restart nodelocaldns daemonset
284-
t.Log("Step 6: Testing resource deletion and recreation")
278+
// Step 5: Delete and recreate resources & restart nodelocaldns daemonset
279+
t.Log("Step 5: Testing resource deletion and recreation")
285280
recreatedPod := deleteAndRecreateResources(t, ctx, cs, clientPod)
286281

287-
// Step 7: Re-establish port forward to new node-local-dns pod and validate metrics
288-
t.Log("Step 7: Re-establishing port forward to new node-local-dns pod for metrics validation")
282+
// Step 6: Re-establish port forward to new node-local-dns pod and validate metrics
283+
t.Log("Step 6: Re-establishing port forward to new node-local-dns pod for metrics validation")
289284

290285
// Get the new node-local-dns pod on the same node as our recreated client pod
291286
nodeName := recreatedPod.Spec.NodeName
@@ -325,8 +320,8 @@ func testLRPLifecycle(t *testing.T, ctx context.Context, clientPod corev1.Pod, k
325320

326321
t.Logf("SUCCESS: Metrics validation passed - traffic is being redirected to new node-local-dns pod %s", newNodeLocalDNSPod.Name)
327322

328-
// Step 8: Final cilium validation after node-local-dns restart
329-
t.Log("Step 8: Final cilium validation - ensuring LRP is still active after node-local-dns restart")
323+
// Step 7: Final cilium validation after node-local-dns restart
324+
t.Log("Step 7: Final cilium validation - ensuring LRP is still active after node-local-dns restart")
330325
validateCiliumLRP(t, ctx, cs, config)
331326

332327
}

0 commit comments

Comments
 (0)