Skip to content

Conversation

@ankushbindlish2
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

Adds comprehensive example JSON files for all CloudEndpoints, LocationOperationStatus, OperationStatus, PrivateEndpointConnections, RegisteredServers, ServerEndpoints, StorageSyncServices, SyncGroups, and Workflows operations for the stable 2025-12-01 API version. These examples provide maximum and minimum parameter sets for each operation, supporting documentation and testing.
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    Automation should then add WaitForARMFeedback label.
    ❗If you don't have permissions to remove the label, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review


Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added ARMReview new-api-version resource-manager TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 3, 2025
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.StorageSync-StorageSync
TypeSpec Microsoft.StorageSync
Go sdk/resourcemanager/storagesync/armstoragesync
JavaScript @azure/arm-storagesync
Python azure-mgmt-storagesync
Java com.azure.resourcemanager:azure-resourcemanager-storagesync
C# Azure.ResourceManager.StorageSync

@github-actions github-actions bot added ARMAutoSignedOff ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 3, 2025
@github-actions github-actions bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMAutoSignedOff ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Dec 3, 2025
@github-actions github-actions bot added ARMAutoSignedOff ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 3, 2025
@ankushbindlish2 ankushbindlish2 changed the title Microsoft.StorageSync 2025-12-01 New Apiversion with NO change [DO NOT REVIEW] Microsoft.StorageSync 2025-12-01 New Apiversion with NO change Dec 4, 2025
@ankushbindlish2 ankushbindlish2 changed the title [DO NOT REVIEW] Microsoft.StorageSync 2025-12-01 New Apiversion with NO change [DO NOT MERGE] Microsoft.StorageSync 2025-12-01 New Apiversion with NO change Dec 4, 2025
@ankushbindlish2 ankushbindlish2 changed the title [DO NOT MERGE] Microsoft.StorageSync 2025-12-01 New Apiversion with NO change Microsoft.StorageSync 2025-12-01 New Apiversion with NO change Dec 4, 2025
Replaces separate minimum and maximum set examples with a unified CloudEndpoints_Update example. Updates example references in storagesync.json and removes the obsolete CloudEndpoints_Update_MinimumSet_Gen.json file.
Set the provisioningState property of CloudEndpoint to read-only in both 2022-09-01 and 2025-12-01 API versions. Updated TypeSpec and JSON schema, added client flattening for CloudEndpointUpdateProperties, and included new example files for CloudEndpoints_Update operations.
@github-actions github-actions bot added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 4, 2025
The provisioningState property in CloudEndpoint is no longer marked as readOnly in both the TypeSpec and JSON schema files for 2022-09-01 and 2025-12-01. Updated tspconfig.yaml to use the read-only status schema option for consistency.
@github-actions github-actions bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview labels Dec 4, 2025
@psah434
Copy link
Member

psah434 commented Dec 4, 2025

What version is this a copy of? I see differences between the last stable version 2022-09-01. Also lintdiff is failing which has to be fixed.

@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 4, 2025
@ankushbindlish2
Copy link
Member Author

What version is this a copy of? I see differences between the last stable version 2022-09-01. Also lintdiff is failing which has to be fixed.

I would imagine 2022-09-01 , I just added new api version in main.tsp

ankushbindlish2 and others added 2 commits December 4, 2025 14:04
Moved @armCommonTypesVersion annotations to specific API versions in main.tsp for more granular control. Added suppressions for ProvisioningStateMustBeReadOnly and LroErrorContent in readme.md to address known issues with linting and error model consistency.
@ankushbindlish2 ankushbindlish2 changed the title Microsoft.StorageSync 2025-12-01 New Apiversion with NO change Microsoft.StorageSync 2025-12-01 New ApiVersion . Add changeEnumerationIntervalDays property to CloudEndpoint models Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants