Skip to content

Conversation

@welovej
Copy link
Member

@welovej welovej commented Dec 4, 2025

This PR migrates your latest version (identified by the tag in your readme.md) of swagger to TypeSpec. We already tried our best to make sure the TypeSpec represents same as previous swagger. Since we lack the business knowledge, please validate this PR again to make sure it's functional equivalent as before. The local validation step is at Getting started | TypeSpec Azure

Besides, TypeSpec encourages to follow ARM guidelines. Therefore, some representations in your previous swagger will be fixed to follow these guidelines. When you see differences in your local validation, please keep this note in mind.

Please reach out to TypeSpec Discussions Channel if there is any help needed.

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR has at least one change violating Azure versioning policy (label: VersioningReviewRequired).
    To unblock this PR, either a) introduce a new API version with these changes instead of modifying an existing API version, or b) follow the process at aka.ms/brch.
  • ❌ The required check named Swagger BreakingChange has failed. To unblock this PR, follow the process at aka.ms/brch.


Comment generated by summarize-checks workflow run.

@welovej welovej changed the title Tsp migration for alertsmanagement AlertRuleRecommendations Tyespec migration for alertsmanagement AlertRuleRecommendations Dec 4, 2025
@github-actions github-actions bot added resource-manager TypeSpec Authored with TypeSpec VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required labels Dec 4, 2025
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.AlertsManagement-AlertRuleRecommendations
TypeSpec Microsoft.AlertsManagement
Python azure-mgmt-alertrulerecommendations
Go sdk/resourcemanager/alertrulerecommendations/armalertrulerecommendations
JavaScript @azure/arm-alertrulerecommendations
Java com.azure.resourcemanager:azure-resourcemanager-alertrulerecommendations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Alerts Management resource-manager TypeSpec Authored with TypeSpec VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant