Skip to content

Commit 5a64dbb

Browse files
LiangTheDevDevtools-frontend LUCI CQ
authored andcommitted
Treat browser ui target type as frame target in the frontend.
We are adding a new browser_ui frame target type for browser ui in a webui browser. This change ensures that the new target type is treated as frame target in frondend. The related chromium.src change is at http://crrev.com/c/6990317. Bug: 393144165 Change-Id: If2b3b8ae0f17bee089fa9feb8c16e4e7d4204730 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7018087 Reviewed-by: Danil Somsikov <dsv@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Liang Zhao <lzhao@microsoft.com>
1 parent 412f220 commit 5a64dbb

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

front_end/core/sdk/ChildTargetManager.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ describeWithMockConnection('ChildTargetManager', () => {
5555
['background_page', SDK.Target.Type.FRAME],
5656
['app', SDK.Target.Type.FRAME],
5757
['popup_page', SDK.Target.Type.FRAME],
58+
['browser_ui', SDK.Target.Type.FRAME],
5859
['worker', SDK.Target.Type.Worker],
5960
['shared_worker', SDK.Target.Type.SHARED_WORKER],
6061
['service_worker', SDK.Target.Type.ServiceWorker],

front_end/core/sdk/ChildTargetManager.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,8 @@ export class ChildTargetManager extends SDKModel<EventTypes> implements Protocol
177177
type = Type.FRAME;
178178
} else if (targetInfo.type === 'page') {
179179
type = Type.FRAME;
180+
} else if (targetInfo.type === 'browser_ui') {
181+
type = Type.FRAME;
180182
} else if (targetInfo.type === 'worker') {
181183
type = Type.Worker;
182184
} else if (targetInfo.type === 'worklet') {

0 commit comments

Comments
 (0)