Skip to content

Updated for compatibility with new TypeInfo-based Reflection API #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updated for compatibility with new TypeInfo-based Reflection API #13

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6ee5a7
Updated for compatibility with new TypeInfo API
leonluc-dev Oct 8, 2014
0684bfb
Removed redundant CopyProperties code
leonluc-dev Oct 30, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 39 additions & 18 deletions ObjectExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ namespace System
{
public static class ObjectExtensions
{
private static readonly MethodInfo CloneMethod = typeof(Object).GetMethod("MemberwiseClone", BindingFlags.NonPublic | BindingFlags.Instance);
private static readonly MethodInfo CloneMethod = typeof(Object).GetTypeInfo().GetDeclaredMethod("MemberwiseClone");

public static bool IsPrimitive(this Type type)
public static bool IsValue(this Type type)
{
if (type == typeof(String)) return true;
return (type.IsValueType & type.IsPrimitive);
return type.GetTypeInfo().IsValueType;
}

public static Object Copy(this Object originalObject)
Expand All @@ -22,46 +22,67 @@ private static Object InternalCopy(Object originalObject, IDictionary<Object, Ob
{
if (originalObject == null) return null;
var typeToReflect = originalObject.GetType();
if (IsPrimitive(typeToReflect)) return originalObject;
if (IsValue(typeToReflect)) return originalObject;
if (visited.ContainsKey(originalObject)) return visited[originalObject];
if (typeof(Delegate).IsAssignableFrom(typeToReflect)) return null;
if (typeof(Delegate).GetTypeInfo().IsAssignableFrom(typeToReflect.GetTypeInfo())) return null;
var cloneObject = CloneMethod.Invoke(originalObject, null);
if (typeToReflect.IsArray)
{
var arrayType = typeToReflect.GetElementType();
if (IsPrimitive(arrayType) == false)
if (IsValue(arrayType) == false)
{
Array clonedArray = (Array)cloneObject;
clonedArray.ForEach((array, indices) => array.SetValue(InternalCopy(clonedArray.GetValue(indices), visited), indices));
}

}
visited.Add(originalObject, cloneObject);
CopyFields(originalObject, visited, cloneObject, typeToReflect);
RecursiveCopyBaseTypePrivateFields(originalObject, visited, cloneObject, typeToReflect);
CopyFields(originalObject, visited, cloneObject, typeToReflect,info => !info.IsStatic && !info.FieldType.GetTypeInfo().IsPrimitive);
CopyProperties(originalObject, visited, cloneObject, typeToReflect, info => !info.GetMethod.IsStatic && !info.PropertyType.GetTypeInfo().IsPrimitive);
RecursiveCopyBaseTypeFields(originalObject, visited, cloneObject, typeToReflect);
return cloneObject;
}

private static void RecursiveCopyBaseTypePrivateFields(object originalObject, IDictionary<object, object> visited, object cloneObject, Type typeToReflect)
private static void RecursiveCopyBaseTypeFields(object originalObject, IDictionary<object, object> visited, object cloneObject, Type typeToReflect)
{
if (typeToReflect.BaseType != null)
if (typeToReflect.GetTypeInfo().BaseType != null)
{
RecursiveCopyBaseTypePrivateFields(originalObject, visited, cloneObject, typeToReflect.BaseType);
CopyFields(originalObject, visited, cloneObject, typeToReflect.BaseType, BindingFlags.Instance | BindingFlags.NonPublic, info => info.IsPrivate);
RecursiveCopyBaseTypeFields(originalObject, visited, cloneObject, typeToReflect.GetTypeInfo().BaseType);
CopyFields(originalObject, visited, cloneObject, typeToReflect.GetTypeInfo().BaseType, info => !info.IsStatic && !info.FieldType.GetTypeInfo().IsPrimitive);
CopyProperties(originalObject, visited, cloneObject, typeToReflect.GetTypeInfo().BaseType, info => !info.GetMethod.IsStatic && !info.PropertyType.GetTypeInfo().IsPrimitive);
}
}

private static void CopyFields(object originalObject, IDictionary<object, object> visited, object cloneObject, Type typeToReflect, BindingFlags bindingFlags = BindingFlags.Instance | BindingFlags.NonPublic | BindingFlags.Public | BindingFlags.FlattenHierarchy, Func<FieldInfo, bool> filter = null)
private static void CopyFields(object originalObject, IDictionary<object, object> visited, object cloneObject, Type typeToReflect, Predicate<FieldInfo> filter = null)
{
foreach (FieldInfo fieldInfo in typeToReflect.GetFields(bindingFlags))
List<FieldInfo> filtered = new List<FieldInfo>(typeToReflect.GetTypeInfo().DeclaredFields);
if (filter != null)
{
filtered = filtered.FindAll(filter);
}
foreach (FieldInfo fieldInfo in filtered)
{
if (filter != null && filter(fieldInfo) == false) continue;
if (IsPrimitive(fieldInfo.FieldType)) continue;
var originalFieldValue = fieldInfo.GetValue(originalObject);
var clonedFieldValue = InternalCopy(originalFieldValue, visited);
fieldInfo.SetValue(cloneObject, clonedFieldValue);
}
}

private static void CopyProperties(object originalObject, IDictionary<object, object> visited, object cloneObject, Type typeToReflect, Predicate<PropertyInfo> filter = null)
{
List<PropertyInfo> filtered = new List<PropertyInfo>(typeToReflect.GetTypeInfo().DeclaredProperties);
if(filter != null)
{
filtered = filtered.FindAll(filter);
}
foreach (PropertyInfo propertyInfo in filtered)
{
if (IsValue(propertyInfo.PropertyType)) continue;
var originalFieldValue = propertyInfo.GetValue(originalObject);
var clonedFieldValue = InternalCopy(originalFieldValue, visited);
propertyInfo.SetValue(cloneObject, clonedFieldValue);
}
}
Copy link

@igitur igitur Oct 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why implement CopyProperties? Properties are just setter and getter functions with underlying fields in a different syntax. Those underlying fields should already be copied in the CopyFields() method.

Copy link
Author

@leonluc-dev leonluc-dev Oct 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was actually a oversight on my part. I have corrected this in my latest commit.

public static T Copy<T>(this T original)
{
return (T)Copy((Object)original);
Expand All @@ -87,7 +108,7 @@ public static class ArrayExtensions
{
public static void ForEach(this Array array, Action<Array, int[]> action)
{
if (array.LongLength == 0) return;
if (array.Length == 0) return;
ArrayTraverse walker = new ArrayTraverse(array);
do action(array, walker.Position);
while (walker.Step());
Expand Down Expand Up @@ -128,4 +149,4 @@ public bool Step()
}
}

}
}