test(plugins): strengthen detection service fallback tests and remove obsolete TODO comments

Author: CaddyGlow

ccproxy/core/async_utils.py

@@ -633,13 +633,8 @@ def generate_json_schema() -> dict[str, Any]:
     Returns:
         JSON Schema dictionary
 
-    Raises:
-        ImportError: If required dependencies are not available
     """
-    try:
-        from ccproxy.config.settings import Settings
-    except ImportError as e:
-        raise ImportError(f"Required dependencies not available: {e}") from e
+    from ccproxy.config.settings import Settings
 
     schema = Settings.model_json_schema()
 

ccproxy/plugins/claude_api/detection_service.py

@@ -102,7 +102,6 @@ async def initialize_detection(self) -> ClaudeCacheData:
                 cached=cached,
             )
 
-            # TODO: add proper testing without claude cli installed
             if detected_data is None:
                 raise ValueError("Claude detection failed")
             return detected_data

ccproxy/plugins/codex/detection_service.py

@@ -109,7 +109,6 @@ async def initialize_detection(self) -> CodexCacheData:
                 cached=cached,
             )
 
-            # TODO: add proper testing without codex cli installed
             if detected_data is None:
                 raise ValueError("Codex detection failed")
             return detected_data

tests/unit/plugins/test_claude_detection.py

@@ -22,19 +22,29 @@ async def test_claude_detection_falls_back_when_cli_missing(tmp_path: Path) -> N
     service = ClaudeAPIDetectionService(settings=settings, cli_service=cli_service)
     service.cache_dir = tmp_path
 
+    expected_fallback = service._get_fallback_data()
+
     with (
         patch.object(
             service,
-            "_get_claude_version",
-            AsyncMock(side_effect=FileNotFoundError("missing cli")),
+            "_get_fallback_data",
+            MagicMock(return_value=expected_fallback),
         ),
         patch.object(
             service,
             "_detect_claude_headers",
-            AsyncMock(side_effect=RuntimeError("should not run")),
-        ),
+            AsyncMock(
+                side_effect=FileNotFoundError(
+                    "Claude CLI not found for header detection"
+                )
+            ),
+        ) as mock_detect,
+        patch.object(service, "_save_to_cache", MagicMock()) as mock_save,
     ):
         result = await service.initialize_detection()
 
-    assert result == service._get_fallback_data()
-    assert service.get_cached_data() == result
+    assert cli_service.detect_cli.await_count == 1
+    mock_detect.assert_awaited_once_with("unknown")
+    mock_save.assert_not_called()
+    assert result is expected_fallback
+    assert service.get_cached_data() is expected_fallback

tests/unit/plugins/test_codex_detection.py

@@ -22,19 +22,29 @@ async def test_codex_detection_falls_back_when_cli_missing(tmp_path: Path) -> No
     service = CodexDetectionService(settings=settings, cli_service=cli_service)
     service.cache_dir = tmp_path
 
+    expected_fallback = service._get_fallback_data()
+
     with (
         patch.object(
             service,
-            "_get_codex_version",
-            AsyncMock(side_effect=FileNotFoundError("missing cli")),
+            "_get_fallback_data",
+            MagicMock(return_value=expected_fallback),
         ),
         patch.object(
             service,
             "_detect_codex_headers",
-            AsyncMock(side_effect=RuntimeError("should not run")),
-        ),
+            AsyncMock(
+                side_effect=FileNotFoundError(
+                    "Codex CLI not found for header detection"
+                )
+            ),
+        ) as mock_detect,
+        patch.object(service, "_save_to_cache", MagicMock()) as mock_save,
     ):
         result = await service.initialize_detection()
 
-    assert result == service._get_fallback_data()
-    assert service.get_cached_data() == result
+    assert cli_service.detect_cli.await_count == 1
+    mock_detect.assert_awaited_once_with("unknown")
+    mock_save.assert_not_called()
+    assert result is expected_fallback
+    assert service.get_cached_data() is expected_fallback