Skip to content

Commit 73b511d

Browse files
Merge pull request #31 from CastleCSS/Grid-classes-not-generated-after-$b6
Grid classes not generated after $b6
2 parents 803275f + 6a68d3c commit 73b511d

File tree

4 files changed

+64
-168
lines changed

4 files changed

+64
-168
lines changed

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "castlecss-core",
3-
"version": "2.4.0",
3+
"version": "2.5.0",
44
"description": "CastleCSS a SCSS framework with modular building blocks for the web",
55
"main": "index.js",
66
"scripts": {

sass/layout/grid.scss

Lines changed: 49 additions & 166 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,9 @@
150150

151151
}
152152

153-
/* Grid widths */
153+
/* Grid widths
154+
12 column grid for $b0
155+
*/
154156

155157
@for $i from 1 through 12 {
156158
$width: ($i/12) * 100%;
@@ -173,204 +175,85 @@
173175

174176
.b0_push_none { margin-left: 0; }
175177

176-
// $b1
177-
@media only screen and (min-width: $b1) {
178-
179-
@for $i from 1 through 12 {
180-
$width: ($i/12) * 100%;
181-
182-
@if $i < 10 {
183-
.b1_0#{ $i } { width: $width; }
184-
185-
.b1_push_0#{ $i } { margin-left: $width; }
186-
} @else {
187-
188-
.b1_#{ $i } { width: $width; }
189-
190-
.b1_push_#{ $i } { margin-left: $width; }
191-
}
192-
}
193-
@for $i from 13 through 24 {
194-
$width: ($i/12) * 100%;
195-
}
196-
197-
.g {
198-
margin-left: -$grid-gutter-b1;
199-
200-
> * {
201-
padding-left: $grid-gutter-b1;
202-
}
203-
}
178+
/* 12 column grid for $b1 and $b2 */
179+
@for $b from 1 through 2 {
180+
$breakpoint : map-get($breakpoint-map, $b);
181+
$gutter : map-get($gutter-map, $b);
204182

205-
.b1_push_none { margin-left: 0; }
206-
207-
}
208-
209-
210-
// $b2
211-
@media only screen and (min-width: $b2) {
212-
213-
@for $i from 1 through 12 {
214-
$width: ($i/12) * 100%;
215-
216-
@if $i < 10 {
217-
.b2_0#{ $i } { width: $width; }
218-
219-
.b2_push_0#{ $i } { margin-left: $width; }
220-
} @else {
221-
222-
.b2_#{ $i } { width: $width; }
223-
224-
.b2_push_#{ $i } { margin-left: $width; }
225-
}
226-
@for $i from 13 through 24 {
183+
@media only screen and (min-width: $breakpoint) {
184+
185+
@for $i from 1 through 12 {
227186
$width: ($i/12) * 100%;
228-
}
229-
}
230-
231-
.g {
232-
margin-left: -$grid-gutter-b2;
233-
234-
> * {
235-
padding-left: $grid-gutter-b2;
236-
}
237-
}
238187

239-
.b2_push_none { margin-left: 0; }
188+
@if $i < 10 {
189+
.b#{$b}_0#{ $i } { width: $width; }
240190

241-
}
191+
.b#{$b}_push_0#{ $i } { margin-left: $width; }
192+
} @else {
242193

243-
// $b3
244-
@media only screen and (min-width: $b3) {
245-
246-
@for $i from 1 through 24 {
247-
$width: ($i/24) * 100%;
248-
249-
@if $i < 10 {
250-
.b3_0#{ $i } { width: $width; }
251-
252-
.b3_push_0#{ $i } { margin-left: $width; }
253-
} @else {
254-
.b3_#{ $i } { width: $width; }
255-
256-
.b3_push_#{ $i } { margin-left: $width; }
257-
}
258-
@for $i from 13 through 48 {
259-
$width: ($i/24) * 100%;
260-
}
261-
}
262-
263-
.g {
264-
margin-left: -$grid-gutter-b3;
265-
266-
> * {
267-
padding-left: $grid-gutter-b3;
194+
.b#{$b}_#{ $i } { width: $width; }
268195

196+
.b#{$b}_push_#{ $i } { margin-left: $width; }
197+
}
198+
@for $i from 13 through 24 {
199+
$width: ($i/12) * 100%;
200+
}
269201
}
270-
}
271-
272-
.b3_x5 { width: 20%; }
273-
.b3_x7 { width: 14.28571428571429%; }
274-
275-
.b3_push_none { margin-left: 0; }
276-
277-
}
278-
279-
// $b4
280-
@media only screen and (min-width: $b4) {
281-
282-
@for $i from 1 through 24 {
283-
$width: ($i/24) * 100%;
284-
285-
@if $i < 10 {
286-
.b4_0#{ $i } { width: $width; }
287202

288-
.b4_push_0#{ $i } { margin-left: $width; }
289-
} @else {
290-
291-
.b4_#{ $i } { width: $width; }
292-
293-
.b4_push_#{ $i } { margin-left: $width; }
203+
.g {
204+
margin-left: -#{$gutter};
205+
206+
> * {
207+
padding-left: $gutter;
208+
}
294209
}
295-
}
296210

297-
.g {
298-
margin-left: -$grid-gutter-b4;
299-
300-
> * {
301-
padding-left: $grid-gutter-b4;
302-
}
211+
.b#{$b}_push_none { margin-left: 0; }
303212
}
304-
305-
.b4_x5 { width: 20%; }
306-
.b4_x7 { width: 14.28571428571429%; }
307-
308-
.b4_push_none { margin-left: 0; }
309-
310-
311213
}
312214

313-
// $b5
314-
@media only screen and (min-width: $b5) {
215+
/* 24 column grid for $b3 and higher */
216+
@for $b from 3 through $amount-breakpoints {
217+
$breakpoint : map-get($breakpoint-map, $b);
218+
$gutter : map-get($gutter-map, $b);
219+
220+
@media only screen and (min-width: $breakpoint) {
315221

316222
@for $i from 1 through 24 {
317223
$width: ($i/24) * 100%;
318224

319225
@if $i < 10 {
320-
.b5_0#{ $i } { width: $width; }
321226

322-
.b5_push_0#{ $i } { margin-left: $width; }
227+
.b#{$b}_0#{ $i } { width: $width; }
228+
229+
.b#{$b}_push_0#{ $i } { margin-left: $width; }
230+
323231
} @else {
324232

325-
.b5_#{ $i } { width: $width; }
233+
.b#{$b}_#{ $i } { width: $width; }
326234

327-
.b5_push_#{ $i } { margin-left: $width; }
328-
}
329-
}
330-
331-
.g {
332-
margin-left: -$grid-gutter-b5;
333-
334-
> * {
335-
padding-left: $grid-gutter-b5;
235+
.b#{$b}_push_#{ $i } { margin-left: $width; }
336236
}
337-
}
338-
339-
.b5_x5 { width: 20%; }
340-
.b5_x7 { width: 14.28571428571429%; }
341-
342-
.b5_push_none { margin-left: 0; }
343-
344-
}
345-
// $b6
346-
@media only screen and (min-width: $b6) {
347237

348-
@for $i from 1 through 24 {
349-
$width: ($i/24) * 100%;
350-
351-
@if $i < 10 {
352-
.b6_0#{ $i } { width: $width; }
353-
354-
.b6_push_0#{ $i } { margin-left: $width; }
355-
} @else {
356-
357-
.b6_#{ $i } { width: $width; }
358-
359-
.b6_push_#{ $i } { margin-left: $width; }
238+
@for $i from 13 through 48 {
239+
$width: ($i/24) * 100%;
360240
}
361241
}
362242

363243
.g {
364-
margin-left: -$grid-gutter-b6;
244+
margin-left: -#{$gutter};
365245

366246
> * {
367-
padding-left: $grid-gutter-b6;
247+
padding-left: $gutter;
248+
368249
}
369250
}
370251

371-
.b6_x5 { width: 20%; }
372-
.b6_x7 { width: 14.28571428571429%; }
252+
.b#{$b}_x5 { width: 20%; }
253+
.b#{$b}_x7 { width: 14.28571428571429%; }
373254

374-
.b6_push_none { margin-left: 0; }
255+
.b#{$b}_push_none { margin-left: 0; }
375256

257+
}
258+
376259
}

sass/variables.scss

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,19 @@ $grid-gutter-b4: 16px;
100100
$grid-gutter-b5: 16px;
101101
$grid-gutter-b6: 16px;
102102

103+
/*
104+
Gutter map
105+
Must be the same amount of gutters and $gutter-map as above
106+
*/
107+
$gutter-map: (
108+
1: $grid-gutter-b1,
109+
2: $grid-gutter-b2,
110+
3: $grid-gutter-b3,
111+
4: $grid-gutter-b4,
112+
5: $grid-gutter-b5,
113+
6: $grid-gutter-b6,
114+
);
115+
103116
/*
104117
Default margin and padding
105118
*/

0 commit comments

Comments
 (0)