Initialize iterator on creation.

CelliesProjects · CelliesProjects · commit f584c6e7d756 · 2018-09-04T13:00:41.000+02:00
diff --git a/logger.ino b/logger.ino
@@ -55,14 +55,12 @@ void deleteOldLogFiles()
 
   while ( logFiles.size() > SAVED_LOGFILES )
   {
-    std::list<String>::iterator thisFile;
+    std::list<String>::iterator oldestFile = logFiles.begin();
 
-    thisFile = logFiles.begin();
-
-    String filename = *thisFile;
+    String filename = *oldestFile;
 
     SPIFFS.remove( filename.c_str() );
-    logFiles.erase( thisFile );
+    logFiles.erase( oldestFile );
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -55,14 +55,12 @@ void deleteOldLogFiles()`
`55`	`55`
`56`	`56`	`while ( logFiles.size() > SAVED_LOGFILES )`
`57`	`57`	`{`
`58`		`- std::list<String>::iterator thisFile;`
	`58`	`+ std::list<String>::iterator oldestFile = logFiles.begin();`
`59`	`59`
`60`		`- thisFile = logFiles.begin();`
`61`		`-`
`62`		`- String filename = *thisFile;`
	`60`	`+ String filename = *oldestFile;`
`63`	`61`
`64`	`62`	`SPIFFS.remove( filename.c_str() );`
`65`		`- logFiles.erase( thisFile );`
	`63`	`+ logFiles.erase( oldestFile );`
`66`	`64`	`}`
`67`	`65`	`}`
`68`	`66`