Skip to content

Conversation

@j9liu
Copy link
Contributor

@j9liu j9liu commented Nov 19, 2025

Description

Depends on #1757, so merge that first.

This change removes the non-meaningful bHasKhrTextureTransform properties from FCesiumFeatureIdSetDescription and FCesiumPropertyTexturePropertyDescription. Now, it will always generate nodes to intercept any scale / offset / rotation parsed from KHR_texture_transform.

This simplifies some of the implementation in #1762, so IMO it is a worthwhile and easy change. It also won't break any existing materials because there are already correct default values when sampling feature ID textures anyway.

Issue number or link

Closes #1760.

Author checklist

  • I have done a full self-review of my code.
  • I have updated CHANGES.md with a short summary of my change (for user-facing changes).
  • [ ] I have added or updated unit tests to ensure consistent code coverage as necessary.
  • I have updated the documentation as necessary.

Testing plan

Although #1764 exists, it's still possible to test the actual generation of nodes in the material. Also open 06_CesiumMetadata to check that it still works, since it uses feature ID textures without the KHR_texture_transform extension.

@j9liu j9liu self-assigned this Nov 19, 2025
@j9liu j9liu changed the base branch from main to detect-instanced-features November 19, 2025 16:11
Base automatically changed from detect-instanced-features to main November 19, 2025 18:37
@j9liu j9liu added this to the January 2026 Release milestone Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore KHR_texture_transform distinction for textures in UCesiumFeaturesMetadataComponent

2 participants