[php][divergent_change-01_base] Platform returns a CSV

Author: santakadev

examples/php/php-divergent_change-01_base/src/Controller/CourseStepsGetController.php

@@ -17,49 +17,56 @@ public function __construct(Platform $platform)
 
     public function get(string $courseId): string
     {
-        $csvSteps = $this->platform->findCourseSteps($courseId);
+        $csv = $this->platform->findCourseSteps($courseId);
 
         $results = '[';
 
-        foreach ($csvSteps as $index => $row) {
-            $type     = $row['type'];
+        $csvLines = explode(PHP_EOL, $csv);
+
+        foreach ($csvLines as $index => $row) {
+            $row = str_getcsv($row);
+
+            if (empty($csv)) {
+                continue;
+            }
+
+            $type     = $row[1];
             $duration = 0;
             $points   = 0;
 
             if ($type === 'video') {
-                $duration = $row['duration'] * 1.1; // 1.1 = due to video pauses
+                $duration = $row[3] * 1.1; // 1.1 = due to video pauses
             }
 
             if ($type === 'quiz') {
-                $duration = $row['questions'] * 0.5; // 0.5 = time in minutes per question
+                $duration = $row[2] * 0.5; // 0.5 = time in minutes per question
             }
 
             if ($type !== 'video' && $type !== 'quiz') {
                 continue;
             }
 
             if ($type === 'video') {
-                $points = $row['duration'] * 1.1 * 100;
+                $points = $row[3] * 1.1 * 100;
             }
 
             if ($type === 'quiz') {
-                $points = $row['questions'] * 0.5 * 10;
+                $points = $row[2] * 0.5 * 10;
             }
 
             $results .= json_encode(
                 [
-                    'id' => $row['id'],
-                    'type' => $row['type'],
+                    'id' => $row[0],
+                    'type' => $row[1],
                     'duration' => $duration,
                     'points' => $points
                 ],
                 JSON_THROW_ON_ERROR
             );
 
-            if ($index !== count($csvSteps) - 1) {
+            if ($index !== count($csvLines) - 1) {
                 $results .= ',';
             }
-
         }
 
         $results .= ']';

examples/php/php-divergent_change-01_base/src/Platform.php

@@ -6,5 +6,5 @@
 
 interface Platform
 {
-    public function findCourseSteps(string $courseId): array;
+    public function findCourseSteps(string $courseId): string;
 }

examples/php/php-divergent_change-01_base/tests/Controller/CourseStepsGetTest.php

@@ -16,7 +16,7 @@ public function shouldReturnEmptyStepList(): void
         $platform = $this->createMock(Platform::class);
         $platform
             ->method('findCourseSteps')
-            ->willReturn([]);
+            ->willReturn('');
 
         $sut = new CourseStepsGetController($platform);
 
@@ -32,26 +32,16 @@ public function shouldReturnExistingCourseSteps(): void
         $platform
             ->method('findCourseSteps')
             ->with('73D74817-CC25-477D-BF3E-36130087293F')
-            ->willReturn([
-                [
-                    'id' => 'uuid',
-                    'type' => 'video',
-                    'questions' => null,
-                    'duration' => 13
-                ],
-                [
-                    'id' => 'uuid',
-                    'type' => 'quiz',
-                    'questions' => 5,
-                    'duration' => null
-                ],
-            ]);
+            ->willReturn(
+                '"1","video","","13"
+                "2","quiz","5",""'
+            );
 
         $sut = new CourseStepsGetController($platform);
 
         $results = $sut->get('73D74817-CC25-477D-BF3E-36130087293F');
 
-        $expected = '[{"id":"uuid","type":"video","duration":14.3,"points":1430},{"id":"uuid","type":"quiz","duration":2.5,"points":25}]';
+        $expected = '[{"id":"1","type":"video","duration":14.3,"points":1430},{"id":"2","type":"quiz","duration":2.5,"points":25}]';
         self::assertSame($expected, $results);
     }
 
@@ -62,14 +52,9 @@ public function shouldIgnoreStepsWithInvalidType(): void
         $platform
             ->method('findCourseSteps')
             ->with('73D74817-CC25-477D-BF3E-36130087293F')
-            ->willReturn([
-                [
-                    'id' => 'uuid',
-                    'type' => 'survey',
-                    'questions' => null,
-                    'duration' => 13
-                ]
-            ]);
+            ->willReturn(
+                '"1","survey","","13"'
+            );
 
         $sut = new CourseStepsGetController($platform);