-
Notifications
You must be signed in to change notification settings - Fork 278
Handle pre-contest clarifications #3174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vmcj
wants to merge
7
commits into
DOMjudge:main
Choose a base branch
from
vmcj:jury_clarification_warning
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0071234
Warn jury for clarifications before contest start
vmcj d54c96e
Prevent clarifications before the contest without explicit time
vmcj 4706e75
Display pre-contest clarifications
vmcj 1f77c9a
Allow teams to request clarifications before the contest
vmcj 8342cf2
Don't display clarification time from before contest
vmcj c8c97ec
Don't reference undisclosed problems in clarifications before contest…
vmcj 3a60f88
Don't display clarifications about non-disclosed problems yet
vmcj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
22 changes: 22 additions & 0 deletions
22
webapp/templates/team/partials/clarifications_team.html.twig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| {% if clarifications is not empty or always_display %} | ||
| <h1 class="teamoverview">Clarifications</h1> | ||
| {% if clarifications is empty %} | ||
| <p class="nodata">No clarifications.</p> | ||
| {% else %} | ||
| {% include 'team/partials/clarification_list.html.twig' with {clarifications: clarifications} %} | ||
| {% endif %} | ||
| {% endif %} | ||
|
|
||
| <h1 class="teamoverview">Clarification Requests</h1> | ||
| {% if clarificationRequests is empty %} | ||
| <p class="nodata">No clarification request.</p> | ||
| {% else %} | ||
| {% include 'team/partials/clarification_list.html.twig' with {clarifications: clarificationRequests} %} | ||
| {% endif %} | ||
|
|
||
| <div class="m-1"> | ||
| <a href="{{ path('team_clarification_add') }}" class="btn btn-secondary btn-sm" data-ajax-modal data-ajax-modal-after="initModalClarificationPreviewAdd"> | ||
| Request clarification | ||
| </a> | ||
| </div> | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather reject clar requests before contest start through the API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So instead of letting teams ask them via UI (because they can via API) disallow both via UI & API?
I think I'm fine with that, I want the jury to still be able to send them via API because of imports and suspected we didn't want the extra branch. I did not really like having to add this to the UI but found consistency important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there is no point in asking for clarification for a contest where no data is supposed to be known yet to teams.
Do we have a way to import clarifications through problem upload or what do you mean by "imports" here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
can I go to the toiletis always an important one. But I'm fine with either way.. either the extra branch in the UI or the extra branch in the API.I'm not sure if we have it yet, but I think it's something we should have. In BAPC prelims (multisite over different days) the jury now updates the PDF. But I can imagine a year where we would just also upload the clars directly in case as they don't have the time.