fix(uiSelectCtrl): ensureHighlightVisible triggered with closed dropdown

Stefan Zollinger · Stefan Zollinger · commit 503c08929ff2 · 2017-08-31T11:39:24.000+02:00
This fix ensures that the dropdown actually is open before calling _ensureHighlightVisible. Fixes: angular-ui#2050
diff --git a/src/uiSelectController.js b/src/uiSelectController.js
@@ -158,7 +158,7 @@ uis.controller('uiSelectCtrl',
       } else {
         $timeout(function () {
           ctrl.focusSearchInput(initSearchValue);
-          if(!ctrl.tagging.isActivated && ctrl.items.length > 1) {
+          if(!ctrl.tagging.isActivated && ctrl.items.length > 1 && ctrl.open) {
             _ensureHighlightVisible();
           }
         });

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ uis.controller('uiSelectCtrl',`
`158`	`158`	`} else {`
`159`	`159`	`$timeout(function () {`
`160`	`160`	`ctrl.focusSearchInput(initSearchValue);`
`161`		`- if(!ctrl.tagging.isActivated && ctrl.items.length > 1) {`
	`161`	`+ if(!ctrl.tagging.isActivated && ctrl.items.length > 1 && ctrl.open) {`
`162`	`162`	`_ensureHighlightVisible();`
`163`	`163`	`}`
`164`	`164`	`});`