Remove the need to have custom local RemoteCertificateValidationCallback and use the microsoft version instead after address the depdency conflict in test project

Author: Tien Nguyen

src/AdoNetCore.AseClient/AseConnection.cs

@@ -3,7 +3,6 @@
 using System.Data;
 using System.Data.Common;
 using System.Net.Security;
-using System.Security.Cryptography.X509Certificates;
 using AdoNetCore.AseClient.Interface;
 using AdoNetCore.AseClient.Internal;
 
@@ -676,14 +675,4 @@ public AseTransaction Transaction
     /// the TraceEnter and TraceExit events.</para>
     /// </remarks>
     public delegate void TraceExitEventHandler(AseConnection connection, object source, string method, object returnValue);
-
-    /// <summary>
-    /// Verifies the remote Secure Sockets Layer (SSL) certificate used for authentication.
-    /// </summary>
-    /// <param name="sender">An object that contains state information for this validation.</param>
-    /// <param name="certificate">The certificate used to authenticate the remote party.</param>
-    /// <param name="chain">The chain of certificate authorities associated with the remote certificate.</param>
-    /// <param name="sslPolicyErrors">One or more errors associated with the remote certificate.</param>
-    /// <returns>A System.Boolean value that determines whether the specified certificate is accepted for authentication.</returns>
-    public delegate bool RemoteCertificateValidationCallback(object sender, X509Certificate certificate, X509Chain chain, SslPolicyErrors sslPolicyErrors);
 }

src/AdoNetCore.AseClient/Interface/IConnectionPoolManager.cs

@@ -1,3 +1,5 @@
+using System.Net.Security;
+
 namespace AdoNetCore.AseClient.Interface
 {
     internal interface IConnectionPoolManager

src/AdoNetCore.AseClient/Internal/ConnectionPoolManager.cs

@@ -2,6 +2,7 @@
 using System.Collections;
 using System.Collections.Concurrent;
 using System.Collections.Generic;
+using System.Net.Security;
 using AdoNetCore.AseClient.Interface;
 
 namespace AdoNetCore.AseClient.Internal

src/AdoNetCore.AseClient/Internal/InternalConnectionFactory.cs

@@ -19,7 +19,7 @@ namespace AdoNetCore.AseClient.Internal
     internal class InternalConnectionFactory : IInternalConnectionFactory
     {
         private readonly IConnectionParameters _parameters;
-        private readonly System.Net.Security.RemoteCertificateValidationCallback _userCertificateValidationCallback;
+        private readonly RemoteCertificateValidationCallback _userCertificateValidationCallback;
 
 
 #if ENABLE_ARRAY_POOL
@@ -34,7 +34,7 @@ public InternalConnectionFactory(IConnectionParameters parameters, RemoteCertifi
 #endif
         {
             _parameters = parameters;
-            _userCertificateValidationCallback = userCertificateValidationCallback == null ? UserCertificateValidationCallback : new System.Net.Security.RemoteCertificateValidationCallback(userCertificateValidationCallback);
+            _userCertificateValidationCallback = userCertificateValidationCallback ?? UserCertificateValidationCallback;
 
 #if ENABLE_ARRAY_POOL
             _arrayPool = arrayPool;

test/AdoNetCore.AseClient.Tests/AdoNetCore.AseClient.Tests.csproj

@@ -10,6 +10,7 @@
     <PackageReference Include="Newtonsoft.Json" Version="12.0.2" />
     <PackageReference Include="NUnit" Version="3.12.0" />
     <PackageReference Include="NUnit3TestAdapter" Version="3.13.0" />
+    
     <PackageReference Include="System.Text.Encoding.CodePages" Version="4.5.1" />
   </ItemGroup>
   <ItemGroup>
@@ -34,9 +35,11 @@
   </PropertyGroup>
   <ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp1.0' ">
     <PackageReference Include="System.Data.Common" Version="4.3.0" />
+    <PackageReference Include="System.Net.Security" Version="4.3.2" />
   </ItemGroup>
   <ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp1.1' ">
     <PackageReference Include="System.Data.Common" Version="4.3.0" />
+    <PackageReference Include="System.Net.Security" Version="4.3.2" />
   </ItemGroup>
   <ItemGroup Condition="'$(TargetFramework)' == 'net46'">
     <PackageReference Include="Sybase.AdoNet4.AseClient">

test/AdoNetCore.AseClient.Tests/Unit/AseConnectionTests.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Data;
+using System.Net.Security;
 using AdoNetCore.AseClient.Interface;
 using AdoNetCore.AseClient.Internal;
 using Moq;