Fixed so that PoolSize cannot become negative. Made sure pooling not kicked off if _parameters.Pooling==false

Toby Steele · Toby Steele · commit 4f306c6cb5e2 · 2019-12-13T14:38:58.000-06:00
diff --git a/src/AdoNetCore.AseClient/Internal/ConnectionPool.cs b/src/AdoNetCore.AseClient/Internal/ConnectionPool.cs
@@ -36,7 +36,7 @@ public ConnectionPool(IConnectionParameters parameters, IInternalConnectionFacto
 
             PoolSize = 0;
 
-            if (_parameters.MinPoolSize > 0)
+            if (_parameters.Pooling && _parameters.MinPoolSize > 0)
             {
                 Task.Run(TryFillPoolToMinSize);
                 Logger.Instance?.WriteLine("Pool fill task started");
@@ -260,7 +260,10 @@ private void RemoveConnection(IInternalConnection connection = null)
                 }
                 finally
                 {
-                    PoolSize--;
+                    if (PoolSize > 0)
+                    {
+                        PoolSize--;
+                    }
                 }
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ public ConnectionPool(IConnectionParameters parameters, IInternalConnectionFacto`
`36`	`36`
`37`	`37`	`PoolSize = 0;`
`38`	`38`
`39`		`- if (_parameters.MinPoolSize > 0)`
	`39`	`+ if (_parameters.Pooling && _parameters.MinPoolSize > 0)`
`40`	`40`	`{`
`41`	`41`	`Task.Run(TryFillPoolToMinSize);`
`42`	`42`	`Logger.Instance?.WriteLine("Pool fill task started");`
`@@ -260,7 +260,10 @@ private void RemoveConnection(IInternalConnection connection = null)`
`260`	`260`	`}`
`261`	`261`	`finally`
`262`	`262`	`{`
`263`		`- PoolSize--;`
	`263`	`+ if (PoolSize > 0)`
	`264`	`+ {`
	`265`	`+ PoolSize--;`
	`266`	`+ }`
`264`	`267`	`}`
`265`	`268`	`}`
`266`	`269`	`}`