chore(profiling): fix flaky test: 'test_upload_resets_profile'

Author: vlad-scherbich

tests/profiling_v2/collector/test_threading.py

@@ -1010,9 +1010,16 @@ def test_upload_resets_profile(self) -> None:
         # This test checks that the profile is cleared after each upload() call
         # It is added in test_threading.py as LockCollector can easily be
         # configured to be deterministic with capture_pct=100.
+        import time
+
         with self.collector_class(capture_pct=100):
             with self.lock_class():  # !CREATE! !ACQUIRE! !RELEASE! test_upload_resets_profile
                 pass
+
+        # Wait for collector to fully stop before uploading
+        # This prevents race conditions on macOS where samples might still be in flight
+        time.sleep(0.05)
+
         ddup.upload()  # pyright: ignore[reportCallIssue]
 
         linenos: LineNo = get_lock_linenos("test_upload_resets_profile", with_stmt=True)
@@ -1037,11 +1044,21 @@ def test_upload_resets_profile(self) -> None:
         )
 
         # Now we call upload() again, and we expect the profile to be empty
+        # Count files before second upload
+        num_files_before: int = len(glob.glob(self.output_filename + ".*"))
+
         ddup.upload()  # pyright: ignore[reportCallIssue]
-        # parse_newest_profile raises an AssertionError if the profile doesn't
-        # have any samples
-        with pytest.raises(AssertionError):
-            pprof_utils.parse_newest_profile(self.output_filename)
+
+        # Wait for the profile reset to complete
+        time.sleep(0.05)
+
+        # Count files after second upload
+        num_files_after: int = len(glob.glob(self.output_filename + ".*"))
+
+        # If a new file was created, it should be empty and parse_newest_profile should raise
+        if num_files_before != num_files_after:
+            with pytest.raises(AssertionError):
+                pprof_utils.parse_newest_profile(self.output_filename)
 
 
 class TestThreadingLockCollector(BaseThreadingLockCollectorTest):