Skip to content

Commit ee5d57c

Browse files
authored
Restore the cc_utils crate (#1300)
Restore the cc_utils crate That crate is not published and only exists as a way to include cc_utils without all the heavy dependencies of ddcommon. (like in spawn_worker build.rs or php_sidecar_mockgen of dd-trace-php.) Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> Co-authored-by: bob.weinand <bob.weinand@datadoghq.com>
1 parent b627e1c commit ee5d57c

File tree

8 files changed

+32
-9
lines changed

8 files changed

+32
-9
lines changed

Cargo.lock

Lines changed: 9 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ members = [
3333
"ddtelemetry",
3434
"ddtelemetry-ffi",
3535
"tools",
36+
"tools/cc_utils",
3637
"tools/sidecar_mockgen",
3738
"spawn_worker",
3839
"tests/spawn_from_lib",

LICENSE-3rdparty.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
root_name: builder, build_common, tools, datadog-alloc, datadog-crashtracker, ddcommon, ddtelemetry, datadog-ddsketch, datadog-crashtracker-ffi, ddcommon-ffi, datadog-ffe, datadog-ipc, datadog-ipc-macros, tarpc, tarpc-plugins, tinybytes, spawn_worker, datadog-library-config, datadog-library-config-ffi, datadog-live-debugger, datadog-live-debugger-ffi, datadog-profiling, datadog-profiling-protobuf, datadog-profiling-ffi, data-pipeline-ffi, data-pipeline, datadog-trace-protobuf, datadog-trace-stats, datadog-trace-utils, datadog-trace-normalization, dogstatsd-client, datadog-log, datadog-log-ffi, ddsketch-ffi, ddtelemetry-ffi, symbolizer-ffi, datadog-profiling-replayer, datadog-remote-config, datadog-sidecar, datadog-sidecar-macros, datadog-sidecar-ffi, datadog-trace-obfuscation, datadog-tracer-flare, sidecar_mockgen, test_spawn_from_lib
1+
root_name: builder, build_common, tools, datadog-alloc, datadog-crashtracker, ddcommon, ddtelemetry, datadog-ddsketch, datadog-crashtracker-ffi, ddcommon-ffi, datadog-ffe, datadog-ipc, datadog-ipc-macros, tarpc, tarpc-plugins, tinybytes, spawn_worker, cc_utils, datadog-library-config, datadog-library-config-ffi, datadog-live-debugger, datadog-live-debugger-ffi, datadog-profiling, datadog-profiling-protobuf, datadog-profiling-ffi, data-pipeline-ffi, data-pipeline, datadog-trace-protobuf, datadog-trace-stats, datadog-trace-utils, datadog-trace-normalization, dogstatsd-client, datadog-log, datadog-log-ffi, ddsketch-ffi, ddtelemetry-ffi, symbolizer-ffi, datadog-profiling-replayer, datadog-remote-config, datadog-sidecar, datadog-sidecar-macros, datadog-sidecar-ffi, datadog-trace-obfuscation, datadog-tracer-flare, sidecar_mockgen, test_spawn_from_lib
22
third_party_libraries:
33
- package_name: addr2line
44
package_version: 0.24.2

spawn_worker/Cargo.toml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ fastrand = "2.0.1"
1313
libc = "0.2"
1414

1515
[build-dependencies]
16-
cc = "1.0"
17-
ddcommon = { path = "../ddcommon" }
16+
cc_utils = { path = "../tools/cc_utils" }
1817

1918
[dependencies.windows]
2019
features = [

spawn_worker/build.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
// Copyright 2021-Present Datadog, Inc. https://www.datadoghq.com/
22
// SPDX-License-Identifier: Apache-2.0
33

4-
pub use ddcommon::cc_utils::cc;
4+
pub use cc_utils::cc;
55

66
fn main() {
7-
let mut builder = ddcommon::cc_utils::ImprovedBuild::new();
7+
let mut builder = cc_utils::ImprovedBuild::new();
88
builder
99
.file("src/trampoline.c")
1010
.warnings(true)
@@ -28,7 +28,7 @@ fn main() {
2828
builder.try_compile_executable("trampoline.bin").unwrap();
2929

3030
if !cfg!(target_os = "windows") {
31-
ddcommon::cc_utils::ImprovedBuild::new()
31+
cc_utils::ImprovedBuild::new()
3232
.file("src/ld_preload_trampoline.c")
3333
.link_dynamically("dl")
3434
.warnings(true)
@@ -40,7 +40,7 @@ fn main() {
4040

4141
#[cfg(target_os = "windows")]
4242
{
43-
ddcommon::cc_utils::ImprovedBuild::new()
43+
cc_utils::ImprovedBuild::new()
4444
.file("src/crashtracking_trampoline.cpp") // Path to your C++ file
4545
.warnings(true)
4646
.warnings_into_errors(true)

tools/cc_utils/Cargo.toml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
[package]
2+
edition = "2021"
3+
name = "cc_utils"
4+
version = "0.1.0"
5+
6+
# Important: This crate is not published and only exists as a way to include cc_utils without all the heavy dependencies of ddcommon. (like in spawn_worker build.rs or php_sidecar_mockgen of dd-trace-php.)
7+
8+
[dependencies]
9+
anyhow = {version = "1.0"}
10+
cc = {version = "1.0"}
11+
12+
[lib]
13+
bench = false
14+

tools/cc_utils/src/lib.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
../../../ddcommon/src/cc_utils.rs

tools/docker/Dockerfile.build

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ COPY "datadog-trace-utils/Cargo.toml" "datadog-trace-utils/"
101101
COPY "datadog-trace-stats/Cargo.toml" "datadog-trace-stats/"
102102
COPY "datadog-tracer-flare/Cargo.toml" "datadog-tracer-flare/"
103103
COPY "tools/Cargo.toml" "tools/"
104+
COPY "tools/cc_utils/Cargo.toml" "tools/cc_utils/"
104105
COPY "tools/sidecar_mockgen/Cargo.toml" "tools/sidecar_mockgen/"
105106
COPY "spawn_worker/Cargo.toml" "spawn_worker/"
106107
COPY "tests/spawn_from_lib/Cargo.toml" "tests/spawn_from_lib/"

0 commit comments

Comments
 (0)