AsyncWebSocketResponse - keep request object till WS_EVT_CONNECT event is executed

user code might use HTTP headers information from the request

Author: vortigont

src/AsyncWebSocket.cpp

@@ -801,9 +801,10 @@ void AsyncWebSocket::_handleEvent(AsyncWebSocketClient *client, AwsEventType typ
 
 AsyncWebSocketClient *AsyncWebSocket::_newClient(AsyncWebServerRequest *request) {
   _clients.emplace_back(request, this);
-  // we've just detached AsyncTCP client from AsyncWebServerRequest,
-  // *request was destructed along with response object in AsyncWebSocketClient's c-tor
-  _handleEvent(&_clients.back(), WS_EVT_CONNECT, nullptr /* request */, NULL, 0);
+  // we've just detached AsyncTCP client from AsyncWebServerRequest
+  _handleEvent(&_clients.back(), WS_EVT_CONNECT, request, NULL, 0);
+  // after user code completed CONNECT event callback we can delete req/respose objects
+  delete request;
   return &_clients.back();
 }
 

src/AsyncWebSocket.h

@@ -239,9 +239,7 @@ class AsyncWebSocketClient {
    * @param request
    * @param server
    */
-  AsyncWebSocketClient(AsyncWebServerRequest *request, AsyncWebSocket *server) : AsyncWebSocketClient(request->clientRelease(), server) {
-    delete request;
-  };
+  AsyncWebSocketClient(AsyncWebServerRequest *request, AsyncWebSocket *server) : AsyncWebSocketClient(request->clientRelease(), server) { };
   ~AsyncWebSocketClient();
 
   // client id increments for the given server