Skip to content

Commit 1741499

Browse files
committed
Move wrongly placed test classes to test packages
1 parent 4285a6e commit 1741499

File tree

5 files changed

+26
-20
lines changed

5 files changed

+26
-20
lines changed

hibernate5-jakarta/src/main/java/tools/jackson/datatype/hibernate5/jakarta/Hibernate5JakartaModule.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -171,9 +171,8 @@ public Hibernate5JakartaModule(Mapping mapping, SessionFactory sessionFactory) {
171171
@Override
172172
public void setupModule(SetupContext context)
173173
{
174-
/* First, append annotation introspector (no need to override, esp.
175-
* as we just implement couple of methods)
176-
*/
174+
// First, append annotation introspector (no need to override, esp.
175+
// as we just implement couple of methods)
177176
// Then add serializers we need
178177
AnnotationIntrospector ai = annotationIntrospector();
179178
if (ai != null) {
@@ -192,7 +191,7 @@ protected AnnotationIntrospector annotationIntrospector() {
192191
ai.setUseTransient(isEnabled(Feature.USE_TRANSIENT_ANNOTATION));
193192
return ai;
194193
}
195-
194+
196195
/*
197196
/**********************************************************************
198197
/* Extended API, configuration
Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
package tools.jackson.datatype.hibernate5.jakarta;
22

3-
public class Hibernate5JakartaVersion {
4-
5-
public static String getHibernateVersion(){
3+
public abstract class Hibernate5JakartaVersion
4+
{
5+
public static String getHibernateVersion() {
66
try {
7-
return Class.forName("org.hibernate.Version").getPackage().getImplementationVersion();
7+
// Use Version.getVersionString() instead of Package.getImplementationVersion()
8+
// because the latter returns null in JPMS/module-info contexts
9+
Class<?> versionClass = Class.forName("org.hibernate.Version");
10+
return (String) versionClass.getMethod("getVersionString").invoke(null);
811
} catch (Exception e) {
912
// Should not happen: hibernate not found in the classpath
1013
throw new RuntimeException(e);

hibernate5-jakarta/src/test/java/tools/jackson/datatype/hibernate5/jakarta/ReplacePersistentCollectionTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88
import tools.jackson.databind.DefaultTyping;
99
import tools.jackson.databind.ObjectMapper;
1010
import tools.jackson.databind.json.JsonMapper;
11-
import tools.jackson.datatype.hibernate5.jakarta.BaseTest;
12-
import tools.jackson.datatype.hibernate5.jakarta.Hibernate5JakartaModule;
1311
import tools.jackson.datatype.hibernate5.jakarta.data.Customer;
1412
import tools.jackson.datatype.hibernate5.jakarta.data.Payment;
1513
import tools.jackson.datatype.hibernate5.jakarta.testutil.NoCheckSubTypeValidator;

hibernate6/src/main/java/tools/jackson/datatype/hibernate6/Hibernate6Version.java renamed to hibernate6/src/test/java/tools/jackson/datatype/hibernate6/Hibernate6Version.java

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,20 @@
11
package tools.jackson.datatype.hibernate6;
22

3-
public class Hibernate6Version {
4-
5-
public static String getHibernateVersion(){
3+
public class Hibernate6Version
4+
{
5+
public static String getHibernateVersion() {
66
try {
7-
return Class.forName("org.hibernate.Version").getPackage().getImplementationVersion();
7+
// Use Version.getVersionString() instead of Package.getImplementationVersion()
8+
// because the latter returns null in JPMS/module-info contexts
9+
Class<?> versionClass = Class.forName("org.hibernate.Version");
10+
return (String) versionClass.getMethod("getVersionString").invoke(null);
811
} catch (Exception e) {
912
// Should not happen: hibernate not found in the classpath
1013
throw new RuntimeException(e);
1114
}
1215
}
1316

14-
public static boolean isHibernate6_Plus(){
17+
public static boolean isHibernate6_Plus() {
1518
String version = getHibernateVersion();
1619
String[] split = version.split("\\.");
1720
return split[0].compareTo("6") == 0;

hibernate7/src/main/java/tools/jackson/datatype/hibernate7/Hibernate7Version.java renamed to hibernate7/src/test/java/tools/jackson/datatype/hibernate7/Hibernate7Version.java

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,20 @@
11
package tools.jackson.datatype.hibernate7;
22

3-
public class Hibernate7Version {
4-
5-
public static String getHibernateVersion(){
3+
public class Hibernate7Version
4+
{
5+
public static String getHibernateVersion() {
66
try {
7-
return Class.forName("org.hibernate.Version").getPackage().getImplementationVersion();
7+
// Use Version.getVersionString() instead of Package.getImplementationVersion()
8+
// because the latter returns null in JPMS/module-info contexts
9+
Class<?> versionClass = Class.forName("org.hibernate.Version");
10+
return (String) versionClass.getMethod("getVersionString").invoke(null);
811
} catch (Exception e) {
912
// Should not happen: hibernate not found in the classpath
1013
throw new RuntimeException(e);
1114
}
1215
}
1316

14-
public static boolean isHibernate7_Plus(){
17+
public static boolean isHibernate7_Plus() {
1518
String version = getHibernateVersion();
1619
String[] split = version.split("\\.");
1720
return split[0].compareTo("7") == 0;

0 commit comments

Comments
 (0)