Do not use pooling so that we do not need to clear pool

Author: Jack251970

Plugins/Flow.Launcher.Plugin.BrowserBookmark/ChromiumBookmarkLoader.cs

@@ -155,9 +155,6 @@ private void LoadFaviconsFromDb(string dbPath, List<Bookmark> bookmarks)
             return;
         }
 
-        // Cache connection for pool clean
-        SqliteConnection connection1 = null;
-
         try
         {
             // Since some bookmarks may have same favicon id, we need to record them to avoid duplicates
@@ -167,7 +164,8 @@ private void LoadFaviconsFromDb(string dbPath, List<Bookmark> bookmarks)
             Parallel.ForEach(bookmarks, bookmark =>
             {
                 // Use read-only connection to avoid locking issues
-                var connection = new SqliteConnection($"Data Source={tempDbPath};Mode=ReadOnly");
+                // Do not use pooling so that we do not need to clear pool: https://github.com/dotnet/efcore/issues/26580
+                var connection = new SqliteConnection($"Data Source={tempDbPath};Mode=ReadOnly;Pooling=false");
                 connection.Open();
 
                 try
@@ -221,7 +219,6 @@ ORDER BY b.width DESC
                 {
                     // Cache connection and clear pool after all operations to avoid issue:
                     // ObjectDisposedException: Safe handle has been closed.
-                    connection1 = connection;
                     connection.Close();
                     connection.Dispose();
                 }
@@ -235,11 +232,6 @@ ORDER BY b.width DESC
         // Delete temporary file
         try
         {
-            // https://github.com/dotnet/efcore/issues/26580
-            if (connection1 != null)
-            {
-                SqliteConnection.ClearPool(connection1);
-            }
             File.Delete(tempDbPath);
         }
         catch (Exception ex)

Plugins/Flow.Launcher.Plugin.BrowserBookmark/FirefoxBookmarkLoader.cs

@@ -142,9 +142,6 @@ private void LoadFaviconsFromDb(string dbPath, List<Bookmark> bookmarks)
             return;
         }
 
-        // Cache connection for pool clean
-        SqliteConnection connection1 = null;
-
         try
         {
             // Since some bookmarks may have same favicon id, we need to record them to avoid duplicates
@@ -154,7 +151,8 @@ private void LoadFaviconsFromDb(string dbPath, List<Bookmark> bookmarks)
             Parallel.ForEach(bookmarks, bookmark =>
             {
                 // Use read-only connection to avoid locking issues
-                var connection = new SqliteConnection($"Data Source={tempDbPath};Mode=ReadOnly");
+                // Do not use pooling so that we do not need to clear pool: https://github.com/dotnet/efcore/issues/26580
+                var connection = new SqliteConnection($"Data Source={tempDbPath};Mode=ReadOnly;Pooling=false");
                 connection.Open();
 
                 try
@@ -217,7 +215,6 @@ ORDER BY i.width DESC  -- Select largest icon available
                 {
                     // Cache connection and clear pool after all operations to avoid issue:
                     // ObjectDisposedException: Safe handle has been closed.
-                    connection1 = connection;
                     connection.Close();
                     connection.Dispose();
                 }
@@ -231,11 +228,6 @@ ORDER BY i.width DESC  -- Select largest icon available
         // Delete temporary file
         try
         {
-            // https://github.com/dotnet/efcore/issues/26580
-            if (connection1 != null)
-            {
-                SqliteConnection.ClearPool(connection1);
-            }
             File.Delete(tempDbPath);
         }
         catch (Exception ex)