Allow media files to propagate through dpd middleware (#211)

delsim · GibbsConsulting · commit f6988e9cdfe2 · 2019-12-04T07:03:09.000-08:00
* Move from staticfiles to static in demo template load tag * Update messaging template No test, but should address #209
diff --git a/demo/demo/templates/base.html b/demo/demo/templates/base.html
@@ -2,7 +2,7 @@
 <html>
  <head>
    {% load plotly_dash%}
-   {% load staticfiles%}
+   {% load static%}
    {% load bootstrap4%}
    {% bootstrap_css%}
    {% bootstrap_javascript jquery="full"%}
diff --git a/django_plotly_dash/middleware.py b/django_plotly_dash/middleware.py
@@ -133,12 +133,18 @@ def __call__(self, request):
 
         response = self.get_response(request)
 
-        content = response.content
+        try:
+            content = response.content
+
+            for source, target in self.substitutions:
+                content = content.replace(source, target)
+
+            response.content = content
 
-        for source, target in self.substitutions:
-            content = content.replace(source, target)
+        except AttributeError:
+            # Not all files can contain substitutions, so ignore them
+            pass
 
-        response.content = content
         return response
 
     def _encode(self, string):
diff --git a/django_plotly_dash/templates/django_plotly_dash/plotly_messaging.html b/django_plotly_dash/templates/django_plotly_dash/plotly_messaging.html
@@ -1,4 +1,4 @@
-{%load staticfiles%}
+{%load static%}
 <script src="{%static "channels/js/websocketbridge.js"%}"></script>
 <script>
   if( !window.dpd_wsb ) {
diff --git a/django_plotly_dash/version.py b/django_plotly_dash/version.py
@@ -23,4 +23,4 @@
 
 '''
 
-__version__ = "1.1.2"
+__version__ = "1.1.3"

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-{%load staticfiles%}`
	`1`	`+{%load static%}`
`2`	`2`	`<script src="{%static "channels/js/websocketbridge.js"%}"></script>`
`3`	`3`	`<script>`
`4`	`4`	`if( !window.dpd_wsb ) {`