Skip to content

Commit a03b31e

Browse files
committed
Adjusted tvos and macos
1 parent a98eaa9 commit a03b31e

File tree

3 files changed

+61
-5
lines changed

3 files changed

+61
-5
lines changed

.github/workflows/pull_request.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ jobs:
147147
path: "**/firebase-debug.log"
148148
build-macos:
149149
needs: jobMatrixSetup
150-
runs-on: macos-latest
150+
runs-on: macos-15
151151
strategy:
152152
fail-fast: false
153153
matrix: ${{ fromJson(needs.jobMatrixSetup.outputs.macos_test_jobs_matrix) }}
@@ -182,11 +182,11 @@ jobs:
182182
uses: actions/upload-artifact@v4
183183
if: failure()
184184
with:
185-
name: iOS ${{ env.ARCHIVE_KEY }} Firebase Debug Log
185+
name: macOS ${{ env.ARCHIVE_KEY }} Firebase Debug Log
186186
path: "**/firebase-debug.log"
187187
build-tvos:
188188
needs: jobMatrixSetup
189-
runs-on: macos-latest
189+
runs-on: macos-15
190190
strategy:
191191
fail-fast: false
192192
matrix: ${{ fromJson(needs.jobMatrixSetup.outputs.tvos_test_jobs_matrix) }}
@@ -215,13 +215,13 @@ jobs:
215215
uses: actions/upload-artifact@v4
216216
if: failure()
217217
with:
218-
name: iOS ${{ env.ARCHIVE_KEY }} Test Report HTML
218+
name: tvOS ${{ env.ARCHIVE_KEY }} Test Report HTML
219219
path: "**/build/reports/tests/tvosArm64Test/"
220220
- name: Upload Firebase Debug Log
221221
uses: actions/upload-artifact@v4
222222
if: failure()
223223
with:
224-
name: iOS ${{ env.ARCHIVE_KEY }} Firebase Debug Log
224+
name: tvOS ${{ env.ARCHIVE_KEY }} Firebase Debug Log
225225
path: "**/firebase-debug.log"
226226
build-jvm:
227227
needs: jobMatrixSetup

convention-plugin-test-option/src/main/kotlin/EmulatorJobsMatrix.kt

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ class EmulatorJobsMatrix {
1616
mapOf(
1717
"emulator_jobs_matrix.json" to getEmulatorTaskList(rootProject = rootProject),
1818
"ios_test_jobs_matrix.json" to getIosTestTaskList(rootProject = rootProject),
19+
"macos_test_jobs_matrix.json" to getMacosTestTaskList(rootProject = rootProject),
20+
"tvos_test_jobs_matrix.json" to getTvosTestTaskList(rootProject = rootProject),
1921
"js_test_jobs_matrix.json" to getJsTestTaskList(rootProject = rootProject),
2022
"jvm_test_jobs_matrix.json" to getJvmTestTaskList(rootProject = rootProject)
2123
)
@@ -41,6 +43,28 @@ class EmulatorJobsMatrix {
4143
}
4244
}.map { listOf("cleanTest", it) }
4345

46+
fun getMacosTestTaskList(rootProject: Project): List<List<String>> =
47+
rootProject.subprojects.filter { subProject ->
48+
subProject.name == "test-utils" ||
49+
(rootProject.property("${subProject.name}.skipMacosTests") == "true").not()
50+
}.map { subProject ->
51+
when (val osArch = System.getProperty("os.arch")) {
52+
"arm64", "arm-v8", "aarch64" -> "${subProject.path}:macosArm64Test"
53+
else -> throw Error("Unexpected System.getProperty(\"os.arch\") = $osArch")
54+
}
55+
}.map { listOf("cleanTest", it) }
56+
57+
fun getTvosTestTaskList(rootProject: Project): List<List<String>> =
58+
rootProject.subprojects.filter { subProject ->
59+
subProject.name == "test-utils" ||
60+
(rootProject.property("${subProject.name}.skipTvosTests") == "true").not()
61+
}.map { subProject ->
62+
when (val osArch = System.getProperty("os.arch")) {
63+
"arm64", "arm-v8", "aarch64" -> "${subProject.path}:tvosSimulatorArm64Test"
64+
else -> throw Error("Unexpected System.getProperty(\"os.arch\") = $osArch")
65+
}
66+
}.map { listOf("cleanTest", it) }
67+
4468
fun getJsTestTaskList(rootProject: Project): List<List<String>> =
4569
rootProject.subprojects.filter { subProject ->
4670
subProject.name == "test-utils" ||

gradle.properties

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,38 @@ firebase-messaging.skipIosTests=false
3737
firebase-perf.skipIosTests=false
3838
firebase-storage.skipIosTests=true
3939

40+
# Skip Macos Tests
41+
firebase-analytics.skipMacosTests=true
42+
firebase-app.skipMacosTests=false
43+
firebase-auth.skipMacosTests=false
44+
firebase-common-internal.skipMacosTests=false
45+
firebase-common.skipMacosTests=false
46+
firebase-config.skipMacosTests=false
47+
firebase-crashlytics.skipMacosTests=false
48+
firebase-database.skipMacosTests=false
49+
firebase-firestore.skipMacosTests=false
50+
firebase-functions.skipMacosTests=false
51+
firebase-installations.skipMacosTests=false
52+
firebase-messaging.skipMacosTests=false
53+
firebase-perf.skipMacosTests=false
54+
firebase-storage.skipMacosTests=true
55+
56+
# Skip Tvos Tests
57+
firebase-analytics.skipTvosTests=true
58+
firebase-app.skipTvosTests=false
59+
firebase-auth.skipTvosTests=false
60+
firebase-common-internal.skipTvosTests=false
61+
firebase-common.skipTvosTests=false
62+
firebase-config.skipTvosTests=false
63+
firebase-crashlytics.skipTvosTests=false
64+
firebase-database.skipTvosTests=false
65+
firebase-firestore.skipTvosTests=false
66+
firebase-functions.skipTvosTests=false
67+
firebase-installations.skipTvosTests=false
68+
firebase-messaging.skipTvosTests=false
69+
firebase-perf.skipTvosTests=false
70+
firebase-storage.skipTvosTests=true
71+
4072
# We can have the functionality to skip jvm tests, due to compatibility issues.
4173
firebase-analytics.skipJvmTests=true
4274
firebase-app.skipJvmTests=false

0 commit comments

Comments
 (0)