Skip to content

Commit 2cd20a0

Browse files
authored
Merge pull request #1821 from Haehnchen/feature/plugin-config-file
fix optional plugins dependencies need a config file
2 parents 588eb52 + 3d2186e commit 2cd20a0

File tree

3 files changed

+19
-16
lines changed

3 files changed

+19
-16
lines changed
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
<idea-plugin url="https://www.jetbrains.com/idea">
2+
</idea-plugin>

src/main/resources/META-INF/plugin.xml

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -630,9 +630,9 @@
630630
<depends>org.jetbrains.plugins.yaml</depends>
631631
<depends>de.espend.idea.php.annotation</depends>
632632

633-
<depends optional="true">com.jetbrains.php.dql</depends>
634-
<depends optional="true">de.espend.idea.php.toolbox</depends>
635-
<depends optional="true" config-file="deployment-aware.xml">com.jetbrains.plugins.webDeployment</depends>
633+
<depends config-file="dql.xml" optional="true" >com.jetbrains.php.dql</depends>
634+
<depends config-file="toolbox.xml" optional="true" >de.espend.idea.php.toolbox</depends>
635+
<depends config-file="deployment-aware.xml" optional="true" >com.jetbrains.plugins.webDeployment</depends>
636636
<depends config-file="pay.xml">com.jetbrains.php</depends>
637637

638638
<extensions defaultExtensionNs="de.espend.idea.php.annotation">
@@ -651,19 +651,6 @@
651651
<PhpAnnotationCompletionProvider implementation="fr.adrienbrault.idea.symfony2plugin.translation.annotation.ConstraintMessageAnnotationReferences"/>
652652
</extensions>
653653

654-
<extensions defaultExtensionNs="de.espend.idea.php.toolbox.extension">
655-
<PhpToolboxProviderInterface implementation="fr.adrienbrault.idea.symfony2plugin.external.toolbox.provider.ServiceToolboxProvider"/>
656-
<PhpToolboxProviderInterface implementation="fr.adrienbrault.idea.symfony2plugin.external.toolbox.provider.RoutesToolboxProvider"/>
657-
<PhpToolboxProviderInterface implementation="fr.adrienbrault.idea.symfony2plugin.external.toolbox.provider.TwigToolboxProvider"/>
658-
<PhpToolboxProviderInterface implementation="fr.adrienbrault.idea.symfony2plugin.external.toolbox.provider.TranslationDomainToolboxProvider"/>
659-
<PhpToolboxProviderInterface implementation="fr.adrienbrault.idea.symfony2plugin.external.toolbox.provider.ServiceParameterToolboxProvider"/>
660-
<PhpToolboxProviderInterface implementation="fr.adrienbrault.idea.symfony2plugin.external.toolbox.provider.DoctrineModelProvider"/>
661-
<PhpToolboxProviderInterface implementation="fr.adrienbrault.idea.symfony2plugin.external.toolbox.provider.ControllerToolboxProvider"/>
662-
663-
<PhpToolboxTargetLocator implementation="fr.adrienbrault.idea.symfony2plugin.external.locator.TwigFileToolboxTargetLocator"/>
664-
<PhpToolboxTargetLocator implementation="fr.adrienbrault.idea.symfony2plugin.external.locator.BundleFileToolboxTargetLocator"/>
665-
</extensions>
666-
667654
<actions>
668655

669656
<action id="Symfony.Menu" class="fr.adrienbrault.idea.symfony2plugin.action.SymfonyContainerServiceBuilder">
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
<idea-plugin url="https://www.jetbrains.com/idea">
2+
<extensions defaultExtensionNs="de.espend.idea.php.toolbox.extension">
3+
<PhpToolboxProviderInterface implementation="fr.adrienbrault.idea.symfony2plugin.external.toolbox.provider.ServiceToolboxProvider"/>
4+
<PhpToolboxProviderInterface implementation="fr.adrienbrault.idea.symfony2plugin.external.toolbox.provider.RoutesToolboxProvider"/>
5+
<PhpToolboxProviderInterface implementation="fr.adrienbrault.idea.symfony2plugin.external.toolbox.provider.TwigToolboxProvider"/>
6+
<PhpToolboxProviderInterface implementation="fr.adrienbrault.idea.symfony2plugin.external.toolbox.provider.TranslationDomainToolboxProvider"/>
7+
<PhpToolboxProviderInterface implementation="fr.adrienbrault.idea.symfony2plugin.external.toolbox.provider.ServiceParameterToolboxProvider"/>
8+
<PhpToolboxProviderInterface implementation="fr.adrienbrault.idea.symfony2plugin.external.toolbox.provider.DoctrineModelProvider"/>
9+
<PhpToolboxProviderInterface implementation="fr.adrienbrault.idea.symfony2plugin.external.toolbox.provider.ControllerToolboxProvider"/>
10+
11+
<PhpToolboxTargetLocator implementation="fr.adrienbrault.idea.symfony2plugin.external.locator.TwigFileToolboxTargetLocator"/>
12+
<PhpToolboxTargetLocator implementation="fr.adrienbrault.idea.symfony2plugin.external.locator.BundleFileToolboxTargetLocator"/>
13+
</extensions>
14+
</idea-plugin>

0 commit comments

Comments
 (0)