Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

Commit a53afdb

Browse files
author
Rizchel Dayao
committed
Add linter
1 parent ec6519c commit a53afdb

File tree

2 files changed

+31
-14
lines changed

2 files changed

+31
-14
lines changed

README.md

Lines changed: 21 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -45,21 +45,23 @@ $ export docker_username="YOUR_DOCKER_USERNAME"
4545

4646
### 1. Clone the repo
4747

48-
Clone the `react-redux-api-example` locally. In a terminal, run:
48+
Clone the repo locally. In a terminal, run:
4949

5050
```
51-
$ git clone https://github.com/rizcheldayao/react-redux-api-example.git
51+
$ git clone https://github.com/IBM/deploy-react-kubernetes
5252
```
5353

5454
### 2. Run the application
5555
1. Install [Node.js](https://nodejs.org/en/)
5656
2. Run the following commands in a terminal:
5757

58-
`$ npm install`
58+
```
59+
$ npm install`
5960
60-
`$ npm run build-css`
61+
$ npm run build-css
6162
62-
`$ npm run start`
63+
$ npm run start
64+
```
6365

6466
## Run the application using Docker
6567
1. [Build the image](#1-build-the-image)
@@ -68,18 +70,23 @@ $ git clone https://github.com/rizcheldayao/react-redux-api-example.git
6870
### 1. Build the image
6971

7072
In a terminal, run:
71-
72-
`$ docker build -t $docker_username/deploy-react-kubernetes .`
73+
```
74+
$ docker build -t $docker_username/deploy-react-kubernetes .
75+
```
7376

7477
Your image should be listed by running:
7578

76-
`$ docker images`
79+
```
80+
$ docker images
81+
```
7782

7883
### 1. Run the image
7984

8085
In a terminal, run:
8186

82-
`$ docker run -p 3000:3000 -d $docker_username/deploy-react-kubernetes`
87+
```
88+
$ docker run -p 3000:3000 -d $docker_username/deploy-react-kubernetes
89+
```
8390

8491
You can now access the application at http://localhost:3000
8592

@@ -89,7 +96,10 @@ You can now access the application at http://localhost:3000
8996
2. [Deploy the application](#2-deploy-the-application)
9097

9198
## Prerequisites
92-
* Create a namespace `bx cr namespace-add <your_namespace>`
99+
* Create a namespace
100+
```
101+
$ bx cr namespace-add <your_namespace>
102+
```
93103

94104
### 1. Build Docker image
95105

@@ -98,7 +108,7 @@ In a terminal, run:
98108
$ bx cr build -t registry.<ibm_cloud_region>.bluemix.net/<your_namespace>/deploy-react-kubernetes .
99109
```
100110

101-
### 2. Deploy the application.
111+
### 2. Deploy the application
102112

103113
```
104114
$ kubectl run deploy-react-kubernetes-deployment —-image= registry.<ibm_cloud_region>.bluemix.net/<your_namespace>/deploy-react-kubernetes

package.json

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,16 @@
22
"name": "MovieFinder",
33
"version": "0.0.1",
44
"description": "React Redux application that calls the OMDb api to get information on a specific movie",
5-
"repository": "git+https://github.com/rizcheldayao/react-redux-api-example",
5+
"repository": "git+https://github.com/IBM/deploy-react-kubernetes",
66
"devDependencies": {
7+
"babel-eslint": "^7.2.3",
78
"enzyme": "^2.4.1",
8-
"eslint": "^2.0.0-rc.1",
9+
"eslint": "^4.18.2",
10+
"eslint-config-react-app": "^2.1.0",
11+
"eslint-plugin-flowtype": "^2.46.1",
12+
"eslint-plugin-import": "^2.9.0",
13+
"eslint-plugin-jsx-a11y": "^5.1.1",
14+
"eslint-plugin-react": "^7.7.0",
915
"node-sass": "^4.5.0",
1016
"react-scripts": "^1.1.1",
1117
"redux-logger": "^2.8.1",
@@ -28,6 +34,7 @@
2834
"start": "react-scripts start",
2935
"build": "react-scripts build",
3036
"eject": "react-scripts eject",
31-
"test": "react-scripts test"
37+
"test": "react-scripts test",
38+
"eslint": "eslint . --ext .js"
3239
}
3340
}

0 commit comments

Comments
 (0)