Add tests for resource fungibility plugin (#21)

carlory · web-flow · commit ed9168db78e4 · 2025-06-05T15:38:29.000+08:00
Signed-off-by: carlory &lt;baofa.fan@daocloud.io&gt;
diff --git a/go.mod b/go.mod
@@ -3,6 +3,7 @@ module github.com/inftyai/scheduler
 go 1.24.1
 
 require (
+	github.com/google/go-cmp v0.7.0
 	github.com/inftyai/llmaz v0.1.3
 	k8s.io/api v0.33.1
 	k8s.io/apimachinery v0.33.1
@@ -38,7 +39,6 @@ require (
 	github.com/google/btree v1.1.3 // indirect
 	github.com/google/cel-go v0.23.2 // indirect
 	github.com/google/gnostic-models v0.6.9 // indirect
-	github.com/google/go-cmp v0.7.0 // indirect
 	github.com/google/uuid v1.6.0 // indirect
 	github.com/grpc-ecosystem/go-grpc-prometheus v1.2.0 // indirect
 	github.com/grpc-ecosystem/grpc-gateway/v2 v2.24.0 // indirect
diff --git a/pkg/plugins/resource_fungibility/resource_fungibility.go b/pkg/plugins/resource_fungibility/resource_fungibility.go
@@ -53,10 +53,9 @@ var (
 	resource = "openmodels"
 )
 
-// TODO: get the inference service to extract the flavors.
 type ResourceFungibility struct {
 	handle    framework.Handle
-	dynClient *dynamic.DynamicClient
+	dynClient dynamic.Interface
 }
 
 type flavor struct {
@@ -172,6 +171,11 @@ func (rf *ResourceFungibility) calPreFilterState(ctx context.Context, pod *v1.Po
 		}
 	}
 
+	if len(serviceFlavors) == 0 {
+		s.shouldSkip = true
+		return nil
+	}
+
 	for _, f := range serviceFlavors {
 		if len(f.NodeSelector) == 0 {
 			// Once nodeSelector is empty, which means all nodes are potential candidates,
diff --git a/pkg/plugins/resource_fungibility/resource_fungibility_test.go b/pkg/plugins/resource_fungibility/resource_fungibility_test.go

Original file line number	Diff line number	Diff line change
`@@ -53,10 +53,9 @@ var (`
`53`	`53`	`resource = "openmodels"`
`54`	`54`	`)`
`55`	`55`
`56`		`-// TODO: get the inference service to extract the flavors.`
`57`	`56`	`type ResourceFungibility struct {`
`58`	`57`	`handle framework.Handle`
`59`		`- dynClient *dynamic.DynamicClient`
	`58`	`+ dynClient dynamic.Interface`
`60`	`59`	`}`
`61`	`60`
`62`	`61`	`type flavor struct {`
`@@ -172,6 +171,11 @@ func (rf ResourceFungibility) calPreFilterState(ctx context.Context, pod v1.Po`
`172`	`171`	`}`
`173`	`172`	`}`
`174`	`173`
	`174`	`+ if len(serviceFlavors) == 0 {`
	`175`	`+ s.shouldSkip = true`
	`176`	`+ return nil`
	`177`	`+ }`
	`178`	`+`
`175`	`179`	`for _, f := range serviceFlavors {`
`176`	`180`	`if len(f.NodeSelector) == 0 {`
`177`	`181`	`// Once nodeSelector is empty, which means all nodes are potential candidates,`