-
Notifications
You must be signed in to change notification settings - Fork 23
Deprecate positional out argument in dpnp.minimum and dpnp.maximum
#2659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2659/index.html |
|
Array API standard conformance tests for dpnp=0.20.0dev0=py313h509198e_56 ran successfully. |
e7f1c9d to
75f6a27
Compare
| with pytest.raises(ValueError): | ||
| getattr(dpnp, func)(a, b, out=out) | ||
|
|
||
| @pytest.mark.filterwarnings("ignore::DeprecationWarning") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to pass out=out to mitigate that issue rather than muting warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
numpy.minimum(q,w,out=())
ValueError: The 'out' tuple must have exactly one entry per ufunc output
numpy.minimum(q,w,out=(1,2))
ValueError: The 'out' tuple must have exactly one entry per ufunc output
This PR suggests raising a
DeprecationWarningwhenoutis passed positionally todpnp.minimumanddpnp.maximum.Align with NumPy 2.4