Skip to content

Deprecate positional out argument in dpnp.minimum and dpnp.maximum #2659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
+73 −5
Open

Deprecate positional out argument in dpnp.minimum and dpnp.maximum #2659

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
f519e26
Deprecate positional out argument in dpnp.minimum
vlad-perevezentsev Nov 10, 2025
83ace79
Deprecate positional out argument in dpnp.maximum
vlad-perevezentsev Nov 10, 2025
10ce7b6
Add Warning section to maximum/minimum docs
vlad-perevezentsev Nov 10, 2025
74a0f02
Add warning test
vlad-perevezentsev Nov 10, 2025
c4e350d
Update changelog
vlad-perevezentsev Nov 10, 2025
c0d0e49
Merge master into deprecated_out_arg
vlad-perevezentsev Nov 10, 2025
1cd390b
Update changelog
vlad-perevezentsev Nov 10, 2025
0090fb0
Update Warning section to maximum/minimum docs
vlad-perevezentsev Nov 11, 2025
00fbb7d
Update DeprecationWarning text
vlad-perevezentsev Nov 11, 2025
a893287
Add DPNPBinaryFuncOutKw class to handle positional out deprecation
vlad-perevezentsev Nov 11, 2025
29494e1
Update test_minimum_maximum_out_deprecated
vlad-perevezentsev Nov 11, 2025
e917db4
Merge master into deprecated_out_arg
vlad-perevezentsev Nov 11, 2025
81b1ded
Use wraps to restore proper signature in DPNPBinaryFuncOutKw
vlad-perevezentsev Nov 11, 2025
75f6a27
Merge master into deprecated_out_arg
vlad-perevezentsev Nov 11, 2025
a0e4d77
Avoid DeprecationWarning from dpnp.asfarray in tests
vlad-perevezentsev Nov 11, 2025
7a754f7
Merge master into deprecated_out_arg
vlad-perevezentsev Nov 11, 2025
19f0889
Ignore DeprecationWarning in TestBoundFuncs::test_invalid_out
vlad-perevezentsev Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dpnp/tests/test_binary_ufuncs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ def test_invalid_shape(self, func, shape):
with pytest.raises(ValueError):
getattr(dpnp, func)(a, b, out=out)

@pytest.mark.filterwarnings("ignore::DeprecationWarning")
Copy link
Contributor

@antonwolfy antonwolfy Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to pass out=out to mitigate that issue rather than muting warning.

Copy link
Contributor Author

@vlad-perevezentsev vlad-perevezentsev Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

numpy.minimum(q,w,out=())
ValueError: The 'out' tuple must have exactly one entry per ufunc output

numpy.minimum(q,w,out=(1,2))
ValueError: The 'out' tuple must have exactly one entry per ufunc output

@pytest.mark.parametrize("xp", [dpnp, numpy])
@pytest.mark.parametrize(
"out",
Expand Down
Loading