Remove destroyed instances from stack. Added initial capacity for collections

Author: IntoTheDev

Runtime/Pool.cs

@@ -10,8 +10,10 @@ public sealed class Pool
 		private readonly Quaternion _rotation = default;
 		private readonly Vector3 _scale = default;
 
-		private static readonly Dictionary<int, Pool> _prefabLookup = new Dictionary<int, Pool>();
-		private static readonly Dictionary<int, Pool> _instanceLookup = new Dictionary<int, Pool>();
+		private static readonly Dictionary<int, Pool> _prefabLookup = new Dictionary<int, Pool>(100);
+		private static readonly Dictionary<int, Pool> _instanceLookup = new Dictionary<int, Pool>(10000);
+
+		private const int CAPACITY = 100;
 
 		public Pool(GameObject prefab)
 		{
@@ -24,7 +26,7 @@ public Pool(GameObject prefab)
 				_prefab.gameObject.SetActive(false);
 			}
 
-			_instances = new Stack<Poolable>();
+			_instances = new Stack<Poolable>(CAPACITY);
 			_prefabLookup.Add(prefab.GetHashCode(), this);
 
 			var transform = prefab.transform;
@@ -48,42 +50,37 @@ public static bool TryGetInstancePool(GameObject instance, out Pool pool) =>
 		public void Populate(int count)
 		{
 			for (int i = 0; i < count; i++)
-			{
-				var instance = CreateInstance();
-				_instances.Push(instance);
-			}
+				_instances.Push(CreateInstance());
 		}
 
-		public GameObject Get() =>
-			GetInstance().gameObject;
-
-		public GameObject Get(Transform parent)
+		public GameObject Get()
 		{
 			var instance = GetInstance();
 
-			instance.transform.SetParent(parent);
-
 			return instance.gameObject;
 		}
 
-		public GameObject Get(Transform parent, bool worldPositionStays)
+		public GameObject Get(Transform parent)
 		{
 			var instance = GetInstance();
 
-			instance.transform.SetParent(parent, worldPositionStays);
+			instance.transform.SetParent(parent);
 
 			return instance.gameObject;
 		}
 
-		public GameObject Get(Vector3 position, Quaternion rotation)
+		public GameObject Get(Transform parent, bool worldPositionStays)
 		{
 			var instance = GetInstance();
 
-			instance.transform.SetPositionAndRotation(position, rotation);
+			instance.transform.SetParent(parent, worldPositionStays);
 
 			return instance.gameObject;
 		}
 
+		public GameObject Get(Vector3 position, Quaternion rotation) =>
+			Get(position, rotation, null);
+
 		public GameObject Get(Vector3 position, Quaternion rotation, Transform parent)
 		{
 			var instance = GetInstance();
@@ -111,24 +108,51 @@ public void Release(GameObject instance)
 
 		private Poolable GetInstance()
 		{
-			Poolable instance;
+			int count = _instances.Count;
 
-			if (_instances.Count == 0)
+			if (count != 0)
 			{
-				instance = CreateInstance();
-			}
-			else
-			{
-				instance = _instances.Pop();
+				var instance = _instances.Pop();
 
 				if (instance == null)
+				{
+					count--;
+
+					while (count != 0)
+					{
+						instance = _instances.Pop();
+
+						if (instance != null)
+						{
+							instance.OnGet();
+							instance.gameObject.SetActive(true);
+
+							return instance;
+						}
+
+						count--;
+					}
+
 					instance = CreateInstance();
+					instance.gameObject.SetActive(true);
+
+					return instance;
+				}
 				else
+				{
 					instance.OnGet();
+					instance.gameObject.SetActive(true);
+
+					return instance;
+				}
 			}
+			else
+			{
+				var instance = CreateInstance();
+				instance.gameObject.SetActive(true);
 
-			instance.gameObject.SetActive(true);
-			return instance;
+				return instance;
+			}
 		}
 
 		private Poolable CreateInstance()