Unobserved task exception bugfix

TableDependency.SqlClient.Test/Inheritance/SqlTableDependencyTest.cs

@@ -283,7 +283,7 @@ protected override async Task WaitForNotifications(
                             sqlCommand.CommandTimeout = 0;
                             this.WriteTraceMessage(TraceLevel.Verbose, "Executing WAITFOR command.");
 
-                            using (var sqlDataReader = await sqlCommand.ExecuteReaderAsync(cancellationToken).WithCancellation(cancellationToken))
+                            using (var sqlDataReader = await sqlCommand.ExecuteReaderAsync(cancellationToken))
                             {
                                 if (_throwExceptionInWaitForNotificationsPoint3) throw new Exception();
 

TableDependency.SqlClient.Test/Issue253Test.cs

@@ -0,0 +1,99 @@
+using System;
+using System.Data.SqlClient;
+using System.Threading;
+using System.Threading.Tasks;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+namespace TableDependency.SqlClient.Test
+{
+    [TestClass]
+    public class Issue253Test : Base.SqlTableDependencyBaseTest
+    {
+        private class Issue253Model
+        {
+            public string Id { get; set; }
+        }
+
+        private static readonly string TableName = nameof(Issue253Model);
+
+        private Exception _unobservedTaskException;
+
+        [ClassInitialize]
+        public static void ClassInitialize(TestContext testContext)
+        {
+            using (var sqlConnection = new SqlConnection(ConnectionStringForTestUser))
+            {
+                sqlConnection.Open();
+                using (var sqlCommand = sqlConnection.CreateCommand())
+                {
+                    sqlCommand.CommandText = $"IF OBJECT_ID('[{TableName}]', 'U') IS NOT NULL DROP TABLE [dbo].[{TableName}]";
+                    sqlCommand.ExecuteNonQuery();
+                    sqlCommand.CommandText = $"CREATE TABLE [{TableName}]([Id] [int] NULL)";
+                    sqlCommand.ExecuteNonQuery();
+                }
+            }
+        }
+
+        [ClassCleanup]
+        public static void ClassCleanup()
+        {
+            using (var sqlConnection = new SqlConnection(ConnectionStringForTestUser))
+            {
+                sqlConnection.Open();
+                using (var sqlCommand = sqlConnection.CreateCommand())
+                {
+                    sqlCommand.CommandText = $"IF OBJECT_ID('{TableName}', 'U') IS NOT NULL DROP TABLE [{TableName}];";
+                    sqlCommand.ExecuteNonQuery();
+                }
+            }
+        }
+
+        [TestCategory("SqlServer")]
+        [TestMethod]
+        public void Test()
+        {
+            try
+            {
+                string naming;
+
+                using (var tableDependency = new SqlTableDependency<Issue253Model>(ConnectionStringForTestUser, tableName: TableName))
+                {
+                    tableDependency.OnChanged += (o, args) => { };
+                    tableDependency.Start();
+                    naming = tableDependency.DataBaseObjectsNamingConvention;
+
+                    Thread.Sleep(5000);
+
+                    TaskScheduler.UnobservedTaskException += TaskSchedulerOnUnobservedTaskException;
+                    try
+                    {
+                        tableDependency.Stop();
+
+                        Thread.Sleep(5000);
+
+                        GC.Collect();
+                        GC.WaitForPendingFinalizers();
+                    }
+                    finally
+                    {
+                        TaskScheduler.UnobservedTaskException -= TaskSchedulerOnUnobservedTaskException;
+                    }
+                }
+
+                Assert.IsTrue(base.AreAllDbObjectDisposed(naming));
+                Assert.IsTrue(base.CountConversationEndpoints(naming) == 0);
+            }
+            catch (Exception exception)
+            {
+                Assert.Fail(exception.Message);
+            }
+
+            Assert.IsNull(_unobservedTaskException);
+        }
+
+        private void TaskSchedulerOnUnobservedTaskException(object sender, UnobservedTaskExceptionEventArgs e)
+        {
+            _unobservedTaskException = e.Exception;
+        }
+    }
+}

TableDependency.SqlClient/SqlTableDependency.cs

@@ -1025,7 +1025,7 @@ protected virtual async Task WaitForNotifications(
                             sqlCommand.CommandTimeout = 0;
                             this.WriteTraceMessage(TraceLevel.Verbose, "Executing WAITFOR command.");
 
-                            using (var sqlDataReader = await sqlCommand.ExecuteReaderAsync(cancellationToken).WithCancellation(cancellationToken))
+                            using (var sqlDataReader = await sqlCommand.ExecuteReaderAsync(cancellationToken))
                             {
                                 while (sqlDataReader.Read())
                                 {