Renew analysis config

Author: JaffaKetchup

analysis_options.yaml

@@ -6,4 +6,4 @@ analyzer:
 
 linter:
   rules:
-    avoid_slow_async_io: false
+    avoid_slow_async_io: false

example/lib/src/screens/main/secondary_view/contents/region_selection/components/shape_selector/components/animated_visibility_icon_button.dart

@@ -6,26 +6,20 @@ class _AnimatedVisibilityIconButton extends StatelessWidget {
     this.onPressed,
     this.tooltip,
     required this.isVisible,
-    // This is exactly what we want to do
-    // ignore: avoid_field_initializers_in_const_classes
   }) : _mode = 0;
 
   const _AnimatedVisibilityIconButton.filledTonal({
     required this.icon,
     this.onPressed,
     this.tooltip,
     required this.isVisible,
-    // This is exactly what we want to do
-    // ignore: avoid_field_initializers_in_const_classes
   }) : _mode = 1;
 
   const _AnimatedVisibilityIconButton.filled({
     required this.icon,
     this.onPressed,
     this.tooltip,
     required this.isVisible,
-    // This is exactly what we want to do
-    // ignore: avoid_field_initializers_in_const_classes
   }) : _mode = 2;
 
   final Icon icon;

jaffa_lints.yaml

@@ -102,7 +102,6 @@ linter:
     - one_member_abstracts
     - only_throw_errors
     - overridden_fields
-    - package_api_docs
     - package_names
     - package_prefixed_library_names
     - parameter_assignments
@@ -155,6 +154,7 @@ linter:
     - sort_constructors_first
     - sort_pub_dependencies
     - sort_unnamed_constructors_first
+    - strict_top_level_inference
     - test_types_in_equals
     - throw_in_finally
     - tighten_type_of_initializing_formals
@@ -163,12 +163,14 @@ linter:
     - type_literal_in_constant_pattern
     - unawaited_futures
     - unintended_html_in_doc_comment
+    - unnecessary_async
     - unnecessary_await_in_return
     - unnecessary_brace_in_string_interps
     - unnecessary_breaks
     - unnecessary_const
     - unnecessary_constructor_name
     - unnecessary_getters_setters
+    - unnecessary_ignore
     - unnecessary_lambdas
     - unnecessary_late
     - unnecessary_library_directive
@@ -187,8 +189,10 @@ linter:
     - unnecessary_string_interpolations
     - unnecessary_this
     - unnecessary_to_list_in_spreads
+    - unnecessary_underscores
     - unreachable_from_main
     - unrelated_type_equality_checks
+    - unsafe_variance
     - use_build_context_synchronously
     - use_colored_box
     - use_decorated_box
@@ -200,6 +204,7 @@ linter:
     - use_key_in_widget_constructors
     - use_late_for_private_fields_and_variables
     - use_named_constants
+    - use_null_aware_elements
     - use_raw_strings
     - use_rethrow_when_possible
     - use_setters_to_change_properties
@@ -210,4 +215,4 @@ linter:
     - use_to_and_as_if_applicable
     - use_truncating_division
     - valid_regexps
-    - void_checks
+    - void_checks

lib/src/backend/impls/objectbox/backend/internal.dart

@@ -461,7 +461,7 @@ class _ObjectBoxBackendImpl implements FMTCObjectBoxBackendInternal {
   @override
   Future<Map<String, int>> removeOldestTilesAboveLimit({
     required List<String> storeNames,
-  }) async {
+  }) {
     // By sharing a single completer, all invocations of this method during the
     // debounce period will return the same result at the same time
     if (_rotalResultCompleter?.isCompleted ?? true) {

lib/src/backend/impls/objectbox/backend/internal_workers/standard/worker.dart

@@ -1001,9 +1001,6 @@ Future<void> _worker(
             id: cmd.id,
             data: {'numExportedTiles': numExportedTiles},
           );
-
-          // We don't care what type, we always need to clean up and rethrow
-          // ignore: avoid_catches_without_on_clauses
         } catch (e) {
           exportingRoot.close();
           if (workingDir.existsSync()) {

lib/src/root/recovery.dart

@@ -58,7 +58,7 @@ class RootRecovery {
   ///
   /// {@macro fmtc.rootRecovery.failedDefinition}
   Future<Iterable<({bool isFailed, RecoveredRegion region})>>
-      get recoverableRegions async =>
+      get recoverableRegions =>
           FMTCBackendAccess.internal.listRecoverableRegions().then(
                 (rs) => rs.map(
                   (r) =>
@@ -79,7 +79,7 @@ class RootRecovery {
   }
 
   /// {@macro fmtc.backend.cancelRecovery}
-  Future<void> cancel(int id) async =>
+  Future<void> cancel(int id) =>
       FMTCBackendAccess.internal.cancelRecovery(id: id);
 }