Hook on Windows don't work

[Axel-Amiltone]

Describe the bug
I have configured a global commit-msg Git hook that successfully rejects invalid commit messages when I commit from Git Bash.
However, when I make a commit using Gitnuro, the commit passes without the hook being executed.

What I did

My git bash configuration includes core.hookspath pointing to my global hooks directory where the commit-msg script is located.
My git bash global configuration works for user.name and user.email.

The commit-msg hook works correctly in Git Bash.
Gitnuro seems to ignore or bypass the commit-msg hook.

Expected behavior
Could you please confirm whether Gitnuro supports executing client-side Git hooks such as commit-msg? If this is a limitation or a known issue, it would be helpful to have it addressed or documented.

Desktop (please complete the following information):

• OS: Windows
• Version 1.5.0

[JetpackDuba]

Hello,
It should work as I've just tested it. One issue regarding hooks was the message not being displayed, just a generic error message, but I've just fixed it in 4c70aca

Can you show an example of your commit-msg? In case I'm missing something that I'm not aware of.

[Axel-Amiltone]

Hello,

Here's my global configuration :

And here's my commit-msg in my .githooks folder :

#!/bin/bash

# Exit immediately if any command fails
set -e

# Color Codes
RESET='\033[0m'
RED='\033[0;31m'
YELLOW='\033[0;33m'

BRANCH_NAME=develop

# Check if target branch exists
if ! git show-ref --verify --quiet refs/heads/${BRANCH_NAME}; then
    echo -e ${YELLOW} "The branch '${BRANCH_NAME}' does not exist. Skipping commit-trailer check." ${RESET}
    exit 0
fi

commit_message_file=$1
commit_message=$(<"$commit_message_file")
commit_count=$(git rev-list --count HEAD ^${BRANCH_NAME})

if [[ ${commit_count} -eq 0 ]]; then
    regex='^(Changelog: (added|changed|deprecated|removed|fixed|security|performance|other)\s*)+$'

    exit_code=1
    while read -r line  || [ -n "$line" ]; do
        if [[ "${line}" =~ ${regex} ]]; then
            exit_code=0
        elif [[ ${exit_code} -eq 0 ]]; then
            if [[ ! "${line}" =~ ${regex} ]] && [[ "$line" != "" ]]; then
                exit_code=1
            fi
        fi
    done < ${commit_message_file}

    if [[ ${exit_code} -eq 1 ]]; then
        echo -e ${RED} "ERROR: 'Changelog: <value>' is missing from your commit message." ${RESET}
        echo -e ${YELLOW} "Use: git commit -m \"${commit_message}\" -m \"Changelog: <value>\"" ${RESET}
        echo -e ${YELLOW} "<value>: added changed deprecated removed fixed security performance other" ${RESET}
        exit 1
    fi
fi

This hook should check that the last line of the first commit of a new branch from develop contains a line like this: Changelog: added.
And if I create and push my commit in GitNuro, the commit just work without this line...

I created a new branch demo_gitnuro from develop on a little repo :

And here, we can see the result if I try with GitBash :

[rattlesnake2028]

Hello, I'm interested also

I have this pre-commit hook :

pre-commit

#!/bin/sh

# Bloque le commit de tout fichier .uproject
if git diff --cached --name-only | grep -i "\.uproject$"; then
  echo "You cannot commit any .uproject file"
  exit 1
fi

And the message is not displayed.
I am with 1.5 version also. Maybe outdated now ?

[JetpackDuba]

@rattlesnake2028 can you give me more information about your platform? Also windows?

[rattlesnake2028]

@rattlesnake2028 can you give me more information about your platform? Also windows?

Yes on windows 11

[JetpackDuba]

Hello,

I've found the issue. Apparently JGit (the underlying library for the Git operations) depends on Cygwin to be installed and in the PATH to execute hooks.

It's not ideal but seems to work just fine.