fix callbacks, add tests

Author: Jhut89

src/Responses/FailureResponse.php

@@ -18,15 +18,13 @@ class FailureResponse extends MailchimpResponse
      * @param $body
      * @param $http_code
      * @param callable|null $failure_callback
-     * @throws MailchimpException
      */
     public function __construct($headers, $body, $http_code, callable $failure_callback = null)
     {
         parent::__construct($headers, $body, $http_code);
-        if ($failure_callback && is_callable($failure_callback)) {
+
+        if ($failure_callback) {
             call_user_func($failure_callback);
-        } elseif ($failure_callback && !is_callable($failure_callback)) {
-            throw new MailchimpException("The failure callback is not callable");
         }
     }
 }

src/Responses/SuccessResponse.php

@@ -18,15 +18,13 @@ class SuccessResponse extends MailchimpResponse
      * @param $body
      * @param $http_code
      * @param callable|null $success_callback
-     * @throws MailchimpException
      */
     public function __construct($headers, $body, $http_code, callable $success_callback = null)
     {
         parent::__construct($headers, $body, $http_code);
-        if (is_callable($success_callback)) {
-            call_user_func("foo");
-        } elseif ($success_callback && !is_callable($success_callback)) {
-            throw new MailchimpException("The success callback is not callable");
+
+        if ($success_callback) {
+            call_user_func($success_callback);
         }
     }
 }

tests/Responses/FailureResponseTest.php

@@ -0,0 +1,23 @@
+<?php
+
+
+namespace MailchimpTests\Responses;
+
+
+use MailchimpAPI\Responses\FailureResponse;
+use PHPUnit\Framework\TestCase;
+
+class FailureResponseTest extends TestCase
+{
+    public function testFailureCallback()
+    {
+        $called = false;
+
+        $callback = function () use (&$called) {
+            $called = true;
+        };
+
+        (new FailureResponse([], '', 200, $callback));
+        $this->assertTrue($called == true, 'The callback should be called by FailureResponse');
+    }
+}

tests/Responses/SuccessResponseTest.php

@@ -0,0 +1,23 @@
+<?php
+
+
+namespace MailchimpTests\Responses;
+
+
+use MailchimpAPI\Responses\SuccessResponse;
+use PHPUnit\Framework\TestCase;
+
+class SuccessResponseTest extends TestCase
+{
+    public function testSuccessCallback()
+    {
+        $called = false;
+
+        $callback = function () use (&$called) {
+            $called = true;
+        };
+
+        (new SuccessResponse([], '', 200, $callback));
+        $this->assertTrue($called == true, 'The callback should be called by SuccessResponse');
+    }
+}