pre-commit

Author: Joaopeuko

.github/workflows/test-metatrader5-integration.yml

@@ -1,6 +1,9 @@
 name: Test | Integration Test
 
-on: [push]
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: '0 0 * * 0' # Run every week monday at 00:00
 
 jobs:
   build:

.github/workflows/test-pytest.yaml

@@ -8,11 +8,11 @@ on:
 jobs:
   pytest:
     runs-on: windows-latest
-    
+
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
-      
+
       - name: Set up Python
         uses: actions/setup-python@v4
         with:
@@ -24,16 +24,16 @@ jobs:
           python -m pip install --upgrade pip
           pip install pytest pytest-cov MetaTrader5
           pip install -e .
-        
+
       - name: Run tests with coverage
         run: |
           pytest -k . --cov=mqpy --cov-append --cov-report=term-missing:skip-covered --junitxml=pytest.xml -x | tee pytest-coverage.txt
-          
+
       - name: Generate coverage summary
         shell: pwsh
         run: |
           "## Test Coverage Summary" | Out-File -FilePath summary.md -Encoding utf8
           '```' | Out-File -FilePath summary.md -Append -Encoding utf8
           Get-Content pytest-coverage.txt | Out-File -FilePath summary.md -Append -Encoding utf8
           '```' | Out-File -FilePath summary.md -Append -Encoding utf8
-          Get-Content summary.md | Out-File -FilePath $env:GITHUB_STEP_SUMMARY -Append -Encoding utf8
+          Get-Content summary.md | Out-File -FilePath $env:GITHUB_STEP_SUMMARY -Append -Encoding utf8

tests/conftest.py

@@ -1,33 +1,29 @@
 import pytest
 
+
 @pytest.fixture
 def test_symbols():
     """Provides common test symbols that can be used across tests."""
-    return {
-        "forex": "EURUSD",
-        "indices": "US500",
-        "commodities": "XAUUSD",
-        "crypto": "BTCUSD",
-        "invalid": "INVALID"
-    }
+    return {"forex": "EURUSD", "indices": "US500", "commodities": "XAUUSD", "crypto": "BTCUSD", "invalid": "INVALID"}
+
 
 @pytest.fixture
 def configure_logging():
     """Sets up logging configuration for tests."""
     import logging
-    
+
     root = logging.getLogger()
     for handler in root.handlers[:]:
         root.removeHandler(handler)
-    
+
     handler = logging.StreamHandler()
     formatter = logging.Formatter("%(asctime)s - %(name)s - %(levelname)s - %(message)s")
     handler.setFormatter(formatter)
     root.addHandler(handler)
-    
+
     root.setLevel(logging.INFO)
-    
+
     yield
-    
+
     for handler in root.handlers[:]:
-        root.removeHandler(handler) 
+        root.removeHandler(handler)

tests/integration/test_mt5_connection.py

@@ -30,15 +30,15 @@
             password=os.getenv("MT5_PASSWORD"),
             server=os.getenv("MT5_SERVER"),
             path=os.getenv("MT5_PATH"),
-             ):
+        ):
             logger.info("MT5 initialized successfully")
             mt5.shutdown()
             success = True
             break
-    except Exception as e:
+    except Exception:
         try:
             mt5.initialize()
-        except Exception as e:
+        except Exception:
             logger.info(f"Attempt {attempt+1}: Not ready yet, sleeping...")
             time.sleep(5)
 

tests/test_book.py

@@ -1,126 +1,133 @@
-import pytest
 import logging
 import time
 
-from mqpy.book import Book
 import MetaTrader5 as Mt5
+import pytest
+
+from mqpy.book import Book
 
 
 @pytest.fixture(scope="module", autouse=True)
 def setup_teardown():
     """Set up and tear down MetaTrader5 connection for the test module."""
     if not Mt5.initialize():
         pytest.skip("MetaTrader5 could not be initialized")
-    
+
     time.sleep(5)
-    
+
     yield
-    
+
     Mt5.shutdown()
 
+
 @pytest.fixture
 def symbol():
     """Provides a valid trading symbol for testing."""
     time.sleep(1)
-    
+
     symbols = Mt5.symbols_get()
     if not symbols:
         pytest.skip("No symbols available for testing")
-    
+
     for symbol in symbols:
         if symbol.name == "EURUSD":
             return "EURUSD"
-    
+
     return symbols[0].name
 
+
 def test_book_initialization(symbol, caplog):
     """Test initialization of Book with a real symbol."""
     caplog.set_level(logging.INFO)
     book = Book(symbol)
-    
+
     assert f"The symbol {symbol} was successfully added to the market book" in caplog.text
 
+
 def test_book_get(symbol):
     """Test getting real market book data."""
     book = Book(symbol)
-    
+
     time.sleep(1)
-    
+
     market_data = book.get()
-    
+
     assert market_data is not None
-    
+
     if market_data:
         assert isinstance(market_data, list)
-        
+
         has_bids = any(item.type == Mt5.BOOK_TYPE_SELL for item in market_data)
         has_asks = any(item.type == Mt5.BOOK_TYPE_BUY for item in market_data)
-        
+
         if not (has_bids or has_asks):
             print(f"Warning: No bids or asks found in market book for {symbol}")
-    
+
     book.release()
 
+
 def test_book_release(symbol):
     """Test releasing the market book."""
     book = Book(symbol)
-    
+
     result = book.release()
-    
+
     assert result is True
 
+
 def test_full_workflow(symbol):
     """Test a complete workflow with the real market book."""
     book = Book(symbol)
-    
+
     time.sleep(1)
-    
+
     market_data = book.get()
-    
+
     assert market_data is not None
-    
+
     release_result = book.release()
     assert release_result is True
-    
 
     time.sleep(1)
     data_after_release = book.get()
-    
+
     if data_after_release is not None and len(data_after_release) > 0:
         print("Note: Market book data still available after release")
 
+
 def test_multiple_symbols():
     """Test using Book with multiple symbols simultaneously."""
     symbols = Mt5.symbols_get()
     if len(symbols) < 2:
         pytest.skip("Need at least 2 symbols for this test")
-    
+
     symbol1 = symbols[0].name
     symbol2 = symbols[1].name
-    
+
     book1 = Book(symbol1)
     book2 = Book(symbol2)
-    
+
     time.sleep(1)
-    
+
     data1 = book1.get()
     data2 = book2.get()
-    
+
     assert data1 is not None
     assert data2 is not None
-    
+
     book1.release()
     book2.release()
 
+
 def test_unavailable_symbol(caplog):
     """Test behavior with an unavailable symbol."""
     caplog.set_level(logging.ERROR)
-    
+
     invalid_symbol = "INVALID_SYMBOL_THAT_DOESNT_EXIST"
-    
+
     book = Book(invalid_symbol)
-    
+
     assert "Error adding INVALID_SYMBOL_THAT_DOESNT_EXIST to the market book" in caplog.text
-    
+
     release_result = book.release()
-    assert release_result is False 
+    assert release_result is False