pre-commit

Author: Joaopeuko

.github/workflows/test-metatrader5-integration.yml

@@ -22,10 +22,10 @@ jobs:
       run: |
         # Download MT5 setup
         Invoke-WebRequest -Uri "https://download.mql5.com/cdn/web/metaquotes.software.corp/mt5/mt5setup.exe" -OutFile mt5setup.exe
-        
+
         # Install MT5 silently
         Start-Process -FilePath .\mt5setup.exe -ArgumentList "/auto" -Wait
-        
+
         # Verify installation
         $mtPath = "C:\Program Files\MetaTrader 5\terminal64.exe"
         if (Test-Path $mtPath) {
@@ -45,17 +45,17 @@ jobs:
         # Kill any existing MT5 instances
         taskkill /F /IM terminal64.exe 2>$null
         Start-Sleep -Seconds 3
-        
+
         # Start MT5 with the /desktop parameter as suggested in MQL5 forum
         $process = Start-Process -FilePath "C:\Program Files\MetaTrader 5\terminal64.exe" -ArgumentList "/portable", "/desktop" -PassThru
-        $pid = $process.Id
-        Write-Host "Started MetaTrader 5 terminal with PID $pid using /desktop parameter"
+        $processId = $process.Id
+        Write-Host "Started MetaTrader 5 terminal with PID $processId using /desktop parameter"
         Start-Sleep -Seconds 30
 
     - name: Test MT5 Initialization
       run: |
         # Python script for testing MT5 initialization
-        $script = @"
+        $script = @'
 import sys
 import time
 import MetaTrader5 as mt5
@@ -76,21 +76,21 @@ if result:
     if terminal_info:
         print(f"Terminal info - Path: {terminal_info.path}")
         print(f"Terminal connected: {getattr(terminal_info, 'connected', 'N/A')}")
-    
+
     # Shut down properly
     mt5.shutdown()
 else:
     print("Failed to initialize MetaTrader 5")
 
 # Always exit with success for CI
 sys.exit(0)
-"@
+'@
 
         # Save script to temporary file
         $script | Out-File -FilePath "test_mt5.py" -Encoding utf8
-        
+
         # Run the test
         python test_mt5.py
-        
+
         # Always continue build
         exit 0

example.py

@@ -1,4 +1,5 @@
 """Example trading strategy using the MQL5-Python integration.
+
 This example demonstrates a Moving Average Crossover strategy.
 """
 
@@ -52,6 +53,3 @@
     if trade.days_end():
         trade.close_position("End of the trading day reached.")
         break
-
-print("Finishing the program.")
-print("Program finished.")

examples_of_expert_advisor/__init__.py

@@ -0,0 +1,4 @@
+"""Expert Advisor examples for MetaTrader 5.
+
+This package contains example implementations of various trading strategies.
+""" 

examples_of_expert_advisor/example_sockets_connection.py

@@ -1,4 +1,5 @@
 """Example Expert Advisor demonstrating socket connections with MetaTrader 5.
+
 This example uses stochastic oscillator and moving average indicators to generate trading signals.
 """
 
@@ -50,12 +51,7 @@
 
     # It uses "try" and catch because sometimes it returns None.
     try:
-        # When in doubt how to handle the indicator, print it, it returns a Dictionary.
-        # logger.info(moving_average)
-        # It prints:
-        # {'symbol': 'PETR4', 'time_frame': 1, 'period': 50, 'start_position': 0, 'method': 0,
-        # 'applied_price': 0, 'moving_average_result': 23.103}
-
+        # When in doubt how to handle the indicator, it returns a Dictionary.
         k_now = stochastic_now["k_result"]
         d_now = stochastic_now["d_result"]