visual cleaning

Author: JohnCGriffin

overflow.go

@@ -1,20 +1,22 @@
-// Package overflow offers overflow-checked integer arithmetic operations for int, int32, and int64.
-// Each of the operations returns a result,bool combination.  This was prompted by the need to know
-// when to flow into higher precision types from the math.big library.
-//
-// For instance, assuing a 64 bit machine:
-//
-// 10 + 20 -> 30
-// int(math.MaxInt64) + 1 -> -9223372036854775808
-//
-// whereas
-//
-// overflow.Add(10,20) -> (30, true)
-// overflow.Add(math.MaxInt64,1) -> (0, false)
-//
-// Add, Sub, Mul, Div are for int.  Add64, Add32, etc. are specifically sized.
-//
-// If anybody wishes an unsigned version, submit a pull request for code and new tests.
+/*Package overflow offers overflow-checked integer arithmetic operations
+for int, int32, and int64. Each of the operations returns a
+result,bool combination.  This was prompted by the need to know when
+to flow into higher precision types from the math.big library.
+
+For instance, assuing a 64 bit machine:
+
+10 + 20 -> 30
+int(math.MaxInt64) + 1 -> -9223372036854775808
+
+whereas
+
+overflow.Add(10,20) -> (30, true)
+overflow.Add(math.MaxInt64,1) -> (0, false)
+
+Add, Sub, Mul, Div are for int.  Add64, Add32, etc. are specifically sized.
+
+If anybody wishes an unsigned version, submit a pull request for code
+and new tests. */
 package overflow
 
 //go:generate ./overflow_template.sh

overflow_test.go

@@ -30,16 +30,14 @@ func TestAlgorithms(t *testing.T) {
 
 				// now the verification
 				result, ok := Add8(a8, b8)
-				if ok {
-					if int64(result) != r64 {
-						t.Errorf("failed to fail on %v + %v = %v instead of %v\n", a8, b8, result, r64)
-						errors++
-					}
-				} else {
-					if int64(result) == r64 {
-						t.Fail()
-						errors++
-					}
+				if ok && int64(result) != r64 {
+					t.Errorf("failed to fail on %v + %v = %v instead of %v\n",
+						a8, b8, result, r64)
+					errors++
+				}
+				if !ok && int64(result) == r64 {
+					t.Fail()
+					errors++
 				}
 			}
 
@@ -49,15 +47,13 @@ func TestAlgorithms(t *testing.T) {
 
 				// now the verification
 				result, ok := Sub8(a8, b8)
-				if ok {
-					if int64(result) != r64 {
-						t.Errorf("failed to fail on %v - %v = %v instead of %v\n", a8, b8, result, r64)
-					}
-				} else {
-					if int64(result) == r64 {
-						t.Fail()
-						errors++
-					}
+				if ok && int64(result) != r64 {
+					t.Errorf("failed to fail on %v - %v = %v instead of %v\n",
+						a8, b8, result, r64)
+				}
+				if !ok && int64(result) == r64 {
+					t.Fail()
+					errors++
 				}
 			}
 
@@ -67,16 +63,14 @@ func TestAlgorithms(t *testing.T) {
 
 				// now the verification
 				result, ok := Mul8(a8, b8)
-				if ok {
-					if int64(result) != r64 {
-						t.Errorf("failed to fail on %v * %v = %v instead of %v\n", a8, b8, result, r64)
-						errors++
-					}
-				} else {
-					if int64(result) == r64 {
-						t.Fail()
-						errors++
-					}
+				if ok && int64(result) != r64 {
+					t.Errorf("failed to fail on %v * %v = %v instead of %v\n",
+						a8, b8, result, r64)
+					errors++
+				}
+				if !ok && int64(result) == r64 {
+					t.Fail()
+					errors++
 				}
 			}
 
@@ -86,16 +80,14 @@ func TestAlgorithms(t *testing.T) {
 
 				// now the verification
 				result, _, ok := Quotient8(a8, b8)
-				if ok {
-					if int64(result) != r64 {
-						t.Errorf("failed to fail on %v / %v = %v instead of %v\n", a8, b8, result, r64)
-						errors++
-					}
-				} else {
-					if result != 0 && int64(result) == r64 {
-						t.Fail()
-						errors++
-					}
+				if ok && int64(result) != r64 {
+					t.Errorf("failed to fail on %v / %v = %v instead of %v\n",
+						a8, b8, result, r64)
+					errors++
+				}
+				if !ok && result != 0 && int64(result) == r64 {
+					t.Fail()
+					errors++
 				}
 			}
 		}