[redis] fix crash on invalid credentials

Author: JorgenEvens

cache.php

@@ -98,29 +98,34 @@ function __construct($search = null) { parent::__construct('user', $search); }
 
     if (ENABLE_REDIS) {
         $redis = new Redis();
-        $redis->connect(REDIS_HOST, REDIS_PORT);
 
-        if (!empty(REDIS_PASSWORD))
-            $redis->auth(REDIS_PASSWORD);
+        try {
+            $redis->connect(REDIS_HOST, REDIS_PORT);
 
-        $redis_db = 0;
-        $redis_dbs = $redis->config('GET', 'databases');
-        $redis_db_select = !is_numeric(REDIS_DATABASE) && !empty($redis_dbs);
-        $redis_memory = $redis->info('memory');
+            if (!empty(REDIS_PASSWORD))
+                $redis->auth(REDIS_PASSWORD);
 
-        if (!$redis_db_select)
-            $redis_db = REDIS_DATABASE;
-        else if (!empty($_COOKIE['redis_db']))
-            $redis_db = (int)$_COOKIE['redis_db'];
+            $redis_db = 0;
+            $redis_dbs = $redis->config('GET', 'databases');
+            $redis_db_select = !is_numeric(REDIS_DATABASE) && !empty($redis_dbs);
+            $redis_memory = $redis->info('memory');
 
-        $redis->select($redis_db);
+            if (!$redis_db_select)
+                $redis_db = REDIS_DATABASE;
+            else if (!empty($_COOKIE['redis_db']))
+                $redis_db = (int)$_COOKIE['redis_db'];
 
-        if( is_action('redis_clear') ) {
+            $redis->select($redis_db);
+        } catch(RedisException $ex) {
+            // Failed to connect
+        }
+
+        if( $redis->isConnected() && is_action('redis_clear') ) {
             $redis->flushDb();
             redirect('?');
         }
 
-        if( is_action('redis_delete') ) {
+        if( $redis->isConnected() && is_action('redis_delete') ) {
             $list = redis_keys(get_selector());
 
             foreach ($list as $key => $item)
@@ -817,7 +822,7 @@ function sort_list($list) {
                 </div>
             <?php endif; ?>
 
-            <?php if(ENABLE_REDIS): ?>
+            <?php if(ENABLE_REDIS && $redis->isConnected()): ?>
                 <h2 id="redis">Redis</h2>
                 <div>
                     <h3>Memory <?=human_size(redis_mem('used') + redis_mem('hash'))?> of <?=human_size(redis_mem('total'))?></h3>

demo/index.php

@@ -45,6 +45,28 @@ class CacheDemoClass {
         $memcache->add('type.array', ['abc', 'def']);
         $memcache->add('type.string', 'hello-world');
         $memcache->add('type.ttl.string', 'hello-world', time() + 3600);
+
+        // Redis configuration
+        $redis_host = getenv('REDIS_HOST') ?: '127.0.0.1';
+        $redis_port = getenv('REDIS_PORT') ?: 6379;
+        $redis_password = getenv('REDIS_PASSWORD') ?: null;
+        $redis_database = getenv('REDIS_DATABASE') ?: null;
+
+        $redis = new Redis();
+        try {
+            $redis->connect($redis_host, $redis_port);
+
+            if (!empty($redis_password))
+                $redis->auth($redis_password);
+
+            if (!empty($redis_database))
+                $redis->select($redis_database);
+
+            $redis->sAdd('type.set', 'abc', 'def');
+            $redis->set('type.string', 'hello-world');
+            $redis->setEx('type.ttl.string', 3600, 'hello-world');
+        } catch(Exception $ex) {}
+
     }
 
     require_once('../cache.php');