[0.10] add get_backend for StaticArrays #622
Open
+25
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit b8b53da)
Comment on lines
52
to
57
|
|
||
| [extras] | ||
| StaticArrays = "90137ffa-7385-5640-81b9-e52037218182" | ||
| EnzymeCore = "f151be2c-9106-41f4-ab19-57ee4f262869" | ||
| LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e" | ||
| SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf" |
Member
There was a problem hiding this comment.
Suggested change
| [extras] | |
| StaticArrays = "90137ffa-7385-5640-81b9-e52037218182" | |
| EnzymeCore = "f151be2c-9106-41f4-ab19-57ee4f262869" | |
| LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e" | |
| SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf" |
Since test/Project.toml exists, I think this can be deleted and the StaticArrays entry added to that file instead
Comment on lines
+3
to
+7
| import KernelAbstractions: get_backend, CPU | ||
| using StaticArrays: SizedArray, MArray | ||
|
|
||
| get_backend(A::SizedArray) = get_backend(A.data) | ||
| get_backend(::MArray) = CPU() |
Member
There was a problem hiding this comment.
Suggested change
| import KernelAbstractions: get_backend, CPU | |
| using StaticArrays: SizedArray, MArray | |
| get_backend(A::SizedArray) = get_backend(A.data) | |
| get_backend(::MArray) = CPU() | |
| import KernelAbstractions: get_backend, POCLBackend | |
| using StaticArrays: SizedArray, MArray | |
| get_backend(A::SizedArray) = get_backend(A.data) | |
| get_backend(::MArray) = POCLBackend() |
Reduces the amount of work required when GPU and CPU get removed
| backendT = typeof(backend).name.wrapper # To look through CUDABackend{true, false} | ||
| @test backend isa backendT | ||
|
|
||
| @test KernelAbstractions.get_backend(@MMatrix [1.0]) isa CPU |
Member
There was a problem hiding this comment.
Suggested change
| @test KernelAbstractions.get_backend(@MMatrix [1.0]) isa CPU | |
| @test KernelAbstractions.get_backend(@MMatrix [1.0]) isa KernelAbstractions.POCLBackend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #621