-
Notifications
You must be signed in to change notification settings - Fork 36
Fix MaxListenersExceededWarning in socket event handlers #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Set socket.setMaxListeners(100) to accommodate all event listeners - Updated test mocks to include setMaxListeners method - Prevents false positive memory leak warnings during speed tests
Summary of ChangesHello @sbs44, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a 'MaxListenersExceededWarning' by adjusting the maximum number of event listeners on socket objects. The change ensures that the application can handle a higher volume of event subscriptions without emitting warnings, improving stability and preventing potential issues in scenarios with numerous concurrent socket events. The corresponding test mocks have also been updated to reflect this change. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a MaxListenersExceededWarning by increasing the listener limit on sockets. While this change is functional, my review focuses on a more robust solution that addresses the potential underlying memory leak by using socket.once() instead of socket.on(). Additionally, I've noticed some code duplication in the test files that could be refactored to improve maintainability, which is relevant as these sections were modified in this PR.
- Changed socket event handlers from .on() to .once() - Removed socket.setMaxListeners(100) workaround - Updated test mocks to match new implementation - Addresses code review feedback on proper event cleanup
Fixes #33
Changes
socket.setMaxListeners(100)in therequest()function to accommodate all event listenerssetMaxListenersmethodTesting
node cli.jsand the compiled binary