Skip to content

Conversation

@sbs44
Copy link

@sbs44 sbs44 commented Nov 13, 2025

Fixes #33

Changes

  • Set socket.setMaxListeners(100) in the request() function to accommodate all event listeners
  • Updated test mocks to include the setMaxListeners method

Testing

  • All existing tests pass
  • Verified no warnings appear when running the CLI
  • Tested both with node cli.js and the compiled binary

- Set socket.setMaxListeners(100) to accommodate all event listeners
- Updated test mocks to include setMaxListeners method
- Prevents false positive memory leak warnings during speed tests
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sbs44, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a 'MaxListenersExceededWarning' by adjusting the maximum number of event listeners on socket objects. The change ensures that the application can handle a higher volume of event subscriptions without emitting warnings, improving stability and preventing potential issues in scenarios with numerous concurrent socket events. The corresponding test mocks have also been updated to reflect this change.

Highlights

  • Warning Fix: Addressed and resolved the 'MaxListenersExceededWarning' that could occur in socket event handlers.
  • Socket Configuration: Increased the maximum number of event listeners for socket objects to 100 within the 'request()' function to prevent warnings.
  • Test Updates: Modified test mocks to properly include the 'setMaxListeners' method, ensuring tests reflect the new socket behavior.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a MaxListenersExceededWarning by increasing the listener limit on sockets. While this change is functional, my review focuses on a more robust solution that addresses the potential underlying memory leak by using socket.once() instead of socket.on(). Additionally, I've noticed some code duplication in the test files that could be refactored to improve maintainability, which is relevant as these sections were modified in this PR.

- Changed socket event handlers from .on() to .once()
- Removed socket.setMaxListeners(100) workaround
- Updated test mocks to match new implementation
- Addresses code review feedback on proper event cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MaxListenersExceededWarning when running globally-installed speed-cloudflare-cli

1 participant