From 466eab00b43604aedf7e6f56fbc6c8aa56ac29be Mon Sep 17 00:00:00 2001 From: GroM Date: Thu, 14 Aug 2025 11:27:01 +0200 Subject: [PATCH 1/7] Add missing llvm-floatabi field in custom target files --- ledger_secure_sdk_sys/devices/apex_p/apex_p.json | 1 + ledger_secure_sdk_sys/devices/flex/flex.json | 1 + ledger_secure_sdk_sys/devices/nanosplus/nanosplus.json | 1 + ledger_secure_sdk_sys/devices/nanox/nanox.json | 1 + ledger_secure_sdk_sys/devices/stax/stax.json | 1 + 5 files changed, 5 insertions(+) diff --git a/ledger_secure_sdk_sys/devices/apex_p/apex_p.json b/ledger_secure_sdk_sys/devices/apex_p/apex_p.json index f4931197..632fe371 100644 --- a/ledger_secure_sdk_sys/devices/apex_p/apex_p.json +++ b/ledger_secure_sdk_sys/devices/apex_p/apex_p.json @@ -9,6 +9,7 @@ "linker": "link_wrap.sh", "linker-flavor": "ld.lld", "llvm-target": "thumbv8m.main-none-eabi", + "llvm-floatabi": "soft", "max-atomic-width": 32, "panic-strategy": "abort", "pre-link-args": { diff --git a/ledger_secure_sdk_sys/devices/flex/flex.json b/ledger_secure_sdk_sys/devices/flex/flex.json index e4039ab9..cb7d49ec 100644 --- a/ledger_secure_sdk_sys/devices/flex/flex.json +++ b/ledger_secure_sdk_sys/devices/flex/flex.json @@ -9,6 +9,7 @@ "linker": "link_wrap.sh", "linker-flavor": "ld.lld", "llvm-target": "thumbv8m.main-none-eabi", + "llvm-floatabi": "soft", "max-atomic-width": 32, "panic-strategy": "abort", "pre-link-args": { diff --git a/ledger_secure_sdk_sys/devices/nanosplus/nanosplus.json b/ledger_secure_sdk_sys/devices/nanosplus/nanosplus.json index 5f3d2030..f54624b6 100644 --- a/ledger_secure_sdk_sys/devices/nanosplus/nanosplus.json +++ b/ledger_secure_sdk_sys/devices/nanosplus/nanosplus.json @@ -9,6 +9,7 @@ "linker": "link_wrap.sh", "linker-flavor": "ld.lld", "llvm-target": "thumbv8m.main-none-eabi", + "llvm-floatabi": "soft", "max-atomic-width": 32, "panic-strategy": "abort", "pre-link-args": { diff --git a/ledger_secure_sdk_sys/devices/nanox/nanox.json b/ledger_secure_sdk_sys/devices/nanox/nanox.json index 245672ec..ef40927c 100644 --- a/ledger_secure_sdk_sys/devices/nanox/nanox.json +++ b/ledger_secure_sdk_sys/devices/nanox/nanox.json @@ -10,6 +10,7 @@ "linker": "link_wrap.sh", "linker-flavor": "ld.lld", "llvm-target": "thumbv6m-none-eabi", + "llvm-floatabi": "soft", "panic-strategy": "abort", "pre-link-args": { "ld.lld": [ diff --git a/ledger_secure_sdk_sys/devices/stax/stax.json b/ledger_secure_sdk_sys/devices/stax/stax.json index 035c1e11..c2e93cd0 100644 --- a/ledger_secure_sdk_sys/devices/stax/stax.json +++ b/ledger_secure_sdk_sys/devices/stax/stax.json @@ -9,6 +9,7 @@ "linker": "link_wrap.sh", "linker-flavor": "ld.lld", "llvm-target": "thumbv8m.main-none-eabi", + "llvm-floatabi": "soft", "max-atomic-width": 32, "panic-strategy": "abort", "pre-link-args": { From fe7499f91aa2eece3784e86bf7e13ff61e44782e Mon Sep 17 00:00:00 2001 From: GroM Date: Thu, 14 Aug 2025 11:28:11 +0200 Subject: [PATCH 2/7] Remove unnecessary_transmutes warnings --- ledger_secure_sdk_sys/src/lib.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/ledger_secure_sdk_sys/src/lib.rs b/ledger_secure_sdk_sys/src/lib.rs index 0759acae..bf64a9c8 100644 --- a/ledger_secure_sdk_sys/src/lib.rs +++ b/ledger_secure_sdk_sys/src/lib.rs @@ -2,6 +2,7 @@ #![allow(non_upper_case_globals)] #![allow(non_camel_case_types)] #![allow(non_snake_case)] +#![allow(unnecessary_transmutes)] use core::ffi::c_void; #[cfg(all(feature = "heap"))] From 2f6953a671ff1a8d2e802855c593152aa7aaf7ae Mon Sep 17 00:00:00 2001 From: GroM Date: Thu, 14 Aug 2025 14:18:02 +0200 Subject: [PATCH 3/7] Few fixes --- ledger_device_sdk/src/ecc.rs | 2 +- ledger_device_sdk/src/io_legacy.rs | 2 +- ledger_device_sdk/src/libcall/swap.rs | 2 +- ledger_device_sdk/src/nbgl/nbgl_review.rs | 4 ++-- ledger_device_sdk/src/nbgl/nbgl_streaming_review.rs | 4 ++-- rust-toolchain.toml | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/ledger_device_sdk/src/ecc.rs b/ledger_device_sdk/src/ecc.rs index 7730ab16..0976e5ae 100644 --- a/ledger_device_sdk/src/ecc.rs +++ b/ledger_device_sdk/src/ecc.rs @@ -189,7 +189,7 @@ impl ECPrivateKey { /// [here](https://blog.rust-lang.org/inside-rust/2021/09/06/Splitting-const-generics.html#featuregeneric_const_exprs) pub fn public_key(&self) -> Result, CxError> where - [(); Self::P]:, + [(); Self::P]: Sized, { let mut pubkey = ECPublicKey::<{ Self::P }, TY>::new(self.curve); let err = unsafe { diff --git a/ledger_device_sdk/src/io_legacy.rs b/ledger_device_sdk/src/io_legacy.rs index 80aa84a5..0ad30706 100644 --- a/ledger_device_sdk/src/io_legacy.rs +++ b/ledger_device_sdk/src/io_legacy.rs @@ -472,7 +472,7 @@ impl Comm { G_ux_params.u.pairing_request.pairing_info_len = (_len - 2) as u32; for i in 0..G_ux_params.u.pairing_request.pairing_info_len as usize { G_ux_params.u.pairing_request.pairing_info[i as usize] = - seph_buffer[5 + i] as i8; + seph_buffer[5 + i] as u8; } G_ux_params.u.pairing_request.pairing_info [G_ux_params.u.pairing_request.pairing_info_len as usize] = 0; diff --git a/ledger_device_sdk/src/libcall/swap.rs b/ledger_device_sdk/src/libcall/swap.rs index 8b325e76..b54e886f 100644 --- a/ledger_device_sdk/src/libcall/swap.rs +++ b/ledger_device_sdk/src/libcall/swap.rs @@ -274,7 +274,7 @@ pub fn get_printable_amount_params< debug_print("==> GET_AMOUNT_STR\n"); printable_amount_params.amount_str = unsafe { &(*(libarg.__bindgen_anon_1.get_printable_amount as *mut get_printable_amount_parameters_t)) - .printable_amount as *const i8 as *mut i8 + .printable_amount as *const u8 as *mut i8 }; printable_amount_params diff --git a/ledger_device_sdk/src/nbgl/nbgl_review.rs b/ledger_device_sdk/src/nbgl/nbgl_review.rs index e8f5f33f..ab75a909 100644 --- a/ledger_device_sdk/src/nbgl/nbgl_review.rs +++ b/ledger_device_sdk/src/nbgl/nbgl_review.rs @@ -113,8 +113,8 @@ impl<'a> NbglReview<'a> { let mut tag_value_array: Vec = Vec::new(); for field in v.iter() { let val = nbgl_contentTagValue_t { - item: field.name.as_ptr() as *const i8, - value: field.value.as_ptr() as *const i8, + item: field.name.as_ptr() as *const ::core::ffi::c_char, + value: field.value.as_ptr() as *const ::core::ffi::c_char, ..Default::default() }; tag_value_array.push(val); diff --git a/ledger_device_sdk/src/nbgl/nbgl_streaming_review.rs b/ledger_device_sdk/src/nbgl/nbgl_streaming_review.rs index 58ac9f4c..1de3bf2c 100644 --- a/ledger_device_sdk/src/nbgl/nbgl_streaming_review.rs +++ b/ledger_device_sdk/src/nbgl/nbgl_streaming_review.rs @@ -218,8 +218,8 @@ impl NbglStreamingReview { let mut tag_value_array: Vec = Vec::new(); for field in v.iter() { let val = nbgl_contentTagValue_t { - item: field.name.as_ptr() as *const i8, - value: field.value.as_ptr() as *const i8, + item: field.name.as_ptr() as *const ::core::ffi::c_char, + value: field.value.as_ptr() as *const ::core::ffi::c_char, ..Default::default() }; tag_value_array.push(val); diff --git a/rust-toolchain.toml b/rust-toolchain.toml index a9c14142..271800cb 100644 --- a/rust-toolchain.toml +++ b/rust-toolchain.toml @@ -1,2 +1,2 @@ [toolchain] -channel = "nightly-2024-12-01" \ No newline at end of file +channel = "nightly" \ No newline at end of file From b56ae10de9c25b4ab5a010c91545c05e355bbc85 Mon Sep 17 00:00:00 2001 From: GroM Date: Thu, 14 Aug 2025 15:07:30 +0200 Subject: [PATCH 4/7] Fix types --- ledger_device_sdk/src/io_legacy.rs | 2 +- ledger_device_sdk/src/libcall/swap.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ledger_device_sdk/src/io_legacy.rs b/ledger_device_sdk/src/io_legacy.rs index 0ad30706..fd22a693 100644 --- a/ledger_device_sdk/src/io_legacy.rs +++ b/ledger_device_sdk/src/io_legacy.rs @@ -472,7 +472,7 @@ impl Comm { G_ux_params.u.pairing_request.pairing_info_len = (_len - 2) as u32; for i in 0..G_ux_params.u.pairing_request.pairing_info_len as usize { G_ux_params.u.pairing_request.pairing_info[i as usize] = - seph_buffer[5 + i] as u8; + seph_buffer[5 + i] as core::ffi::c_char; } G_ux_params.u.pairing_request.pairing_info [G_ux_params.u.pairing_request.pairing_info_len as usize] = 0; diff --git a/ledger_device_sdk/src/libcall/swap.rs b/ledger_device_sdk/src/libcall/swap.rs index b54e886f..475d11db 100644 --- a/ledger_device_sdk/src/libcall/swap.rs +++ b/ledger_device_sdk/src/libcall/swap.rs @@ -274,7 +274,7 @@ pub fn get_printable_amount_params< debug_print("==> GET_AMOUNT_STR\n"); printable_amount_params.amount_str = unsafe { &(*(libarg.__bindgen_anon_1.get_printable_amount as *mut get_printable_amount_parameters_t)) - .printable_amount as *const u8 as *mut i8 + .printable_amount as *const core::ffi::c_char as *mut i8 }; printable_amount_params From 87c40e3bd1ec8b9ecd6d676c3845d5e6c00820f4 Mon Sep 17 00:00:00 2001 From: GroM Date: Tue, 18 Nov 2025 12:44:58 +0100 Subject: [PATCH 5/7] bump nightly version --- ledger_device_sdk/src/libcall/swap.rs | 6 +++--- ledger_device_sdk/src/nbgl.rs | 4 ++-- ledger_device_sdk/src/nbgl/nbgl_advance_review.rs | 8 ++++---- ledger_device_sdk/src/nbgl/nbgl_generic_settings.rs | 4 ++-- ledger_device_sdk/src/nbgl/nbgl_streaming_review.rs | 12 ++++++------ ledger_secure_sdk_sys/devices/apex_p/apex_p.json | 2 +- ledger_secure_sdk_sys/devices/flex/flex.json | 2 +- .../devices/nanosplus/nanosplus.json | 2 +- ledger_secure_sdk_sys/devices/nanox/nanox.json | 2 +- ledger_secure_sdk_sys/devices/stax/stax.json | 2 +- rust-toolchain.toml | 2 +- 11 files changed, 23 insertions(+), 23 deletions(-) diff --git a/ledger_device_sdk/src/libcall/swap.rs b/ledger_device_sdk/src/libcall/swap.rs index 475d11db..cdfc8168 100644 --- a/ledger_device_sdk/src/libcall/swap.rs +++ b/ledger_device_sdk/src/libcall/swap.rs @@ -205,7 +205,7 @@ pub fn get_check_address_params< } debug_print("==> GET_REF_ADDRESS\n"); - let (address, address_len) = read_c_string::(params.address_to_check); + let (address, address_len) = read_c_string::(params.address_to_check as *const i8); check_address_params.ref_address = address; check_address_params.ref_address_len = address_len; @@ -340,13 +340,13 @@ pub fn sign_tx_params< } debug_print("==> GET_DESTINATION_ADDRESS\n"); - let (address, address_len) = read_c_string::(params.destination_address); + let (address, address_len) = read_c_string::(params.destination_address as *const i8); create_tx_params.dest_address = address; create_tx_params.dest_address_len = address_len; debug_print("==> GET_DESTINATION_ADDRESS_EXTRA_ID\n"); let (extra_id, extra_id_len) = - read_c_string::(params.destination_address_extra_id); + read_c_string::(params.destination_address_extra_id as *const i8); create_tx_params.dest_address_extra_id = extra_id; create_tx_params.dest_address_extra_id_len = extra_id_len; diff --git a/ledger_device_sdk/src/nbgl.rs b/ledger_device_sdk/src/nbgl.rs index 335233a1..a6d17903 100644 --- a/ledger_device_sdk/src/nbgl.rs +++ b/ledger_device_sdk/src/nbgl.rs @@ -228,8 +228,8 @@ impl From<&Field<'_>> for CField { impl From<&CField> for nbgl_contentTagValue_t { fn from(field: &CField) -> nbgl_contentTagValue_t { nbgl_contentTagValue_t { - item: (*field).name.as_ptr() as *const i8, - value: (*field).value.as_ptr() as *const i8, + item: (*field).name.as_ptr() as *const ::core::ffi::c_char, + value: (*field).value.as_ptr() as *const ::core::ffi::c_char, ..Default::default() } } diff --git a/ledger_device_sdk/src/nbgl/nbgl_advance_review.rs b/ledger_device_sdk/src/nbgl/nbgl_advance_review.rs index 0db80fe8..b22046bc 100644 --- a/ledger_device_sdk/src/nbgl/nbgl_advance_review.rs +++ b/ledger_device_sdk/src/nbgl/nbgl_advance_review.rs @@ -161,10 +161,10 @@ impl<'a> NbglAdvanceReview<'a> { let warning_details = match &self.warning_details_type { Some(w) => nbgl_warning_t { predefinedSet: (1u32 << W3C_RISK_DETECTED_WARN), - dAppProvider: w.dapp_provider_name.as_ptr() as *const i8, - reportUrl: w.report_url.as_ptr() as *const i8, - reportProvider: w.report_provider.as_ptr() as *const i8, - providerMessage: w.provider_message.as_ptr() as *const i8, + dAppProvider: w.dapp_provider_name.as_ptr() as *const ::core::ffi::c_char, + reportUrl: w.report_url.as_ptr() as *const ::core::ffi::c_char, + reportProvider: w.report_provider.as_ptr() as *const ::core::ffi::c_char, + providerMessage: w.provider_message.as_ptr() as *const ::core::ffi::c_char, ..Default::default() }, None => nbgl_warning_t::default(), diff --git a/ledger_device_sdk/src/nbgl/nbgl_generic_settings.rs b/ledger_device_sdk/src/nbgl/nbgl_generic_settings.rs index 0e451d09..89028bdd 100644 --- a/ledger_device_sdk/src/nbgl/nbgl_generic_settings.rs +++ b/ledger_device_sdk/src/nbgl/nbgl_generic_settings.rs @@ -87,8 +87,8 @@ impl NbglGenericSettings { } self.info_list = Some(nbgl_contentInfoList_t { - infoTypes: self.info.fields_ptr[..].as_ptr(), - infoContents: self.info.values_ptr[..].as_ptr(), + infoTypes: self.info.fields_ptr[..].as_ptr() as *const *const ::core::ffi::c_char, + infoContents: self.info.values_ptr[..].as_ptr() as *const *const ::core::ffi::c_char, nbInfos: fields_values.len() as u8, infoExtensions: core::ptr::null(), token: 0, diff --git a/ledger_device_sdk/src/nbgl/nbgl_streaming_review.rs b/ledger_device_sdk/src/nbgl/nbgl_streaming_review.rs index 1de3bf2c..49857cc0 100644 --- a/ledger_device_sdk/src/nbgl/nbgl_streaming_review.rs +++ b/ledger_device_sdk/src/nbgl/nbgl_streaming_review.rs @@ -145,10 +145,10 @@ impl NbglStreamingReview { Some(w) => { let warning_details = nbgl_warning_t { predefinedSet: (1u32 << W3C_RISK_DETECTED_WARN), - dAppProvider: w.dapp_provider_name.as_ptr() as *const i8, - reportUrl: w.report_url.as_ptr() as *const i8, - reportProvider: w.report_provider.as_ptr() as *const i8, - providerMessage: w.provider_message.as_ptr() as *const i8, + dAppProvider: w.dapp_provider_name.as_ptr() as *const ::core::ffi::c_char, + reportUrl: w.report_url.as_ptr() as *const ::core::ffi::c_char, + reportProvider: w.report_provider.as_ptr() as *const ::core::ffi::c_char, + providerMessage: w.provider_message.as_ptr() as *const ::core::ffi::c_char, ..Default::default() }; nbgl_useCaseAdvancedReviewStreamingStart( @@ -271,8 +271,8 @@ impl NbglStreamingReview { let mut tag_value_array: Vec = Vec::new(); for field in v.iter() { let val = nbgl_contentTagValue_t { - item: field.name.as_ptr() as *const i8, - value: field.value.as_ptr() as *const i8, + item: field.name.as_ptr() as *const ::core::ffi::c_char, + value: field.value.as_ptr() as *const ::core::ffi::c_char, ..Default::default() }; tag_value_array.push(val); diff --git a/ledger_secure_sdk_sys/devices/apex_p/apex_p.json b/ledger_secure_sdk_sys/devices/apex_p/apex_p.json index 632fe371..38cf2708 100644 --- a/ledger_secure_sdk_sys/devices/apex_p/apex_p.json +++ b/ledger_secure_sdk_sys/devices/apex_p/apex_p.json @@ -24,7 +24,7 @@ }, "relocation-model": "ropi-rwpi", "singlethread": true, - "target-pointer-width": "32", + "target-pointer-width": 32, "os": "apex_p", "target-family": [ "bolos" ] } diff --git a/ledger_secure_sdk_sys/devices/flex/flex.json b/ledger_secure_sdk_sys/devices/flex/flex.json index cb7d49ec..a54b8bf8 100644 --- a/ledger_secure_sdk_sys/devices/flex/flex.json +++ b/ledger_secure_sdk_sys/devices/flex/flex.json @@ -24,7 +24,7 @@ }, "relocation-model": "ropi-rwpi", "singlethread": true, - "target-pointer-width": "32", + "target-pointer-width": 32, "os": "flex", "target-family": [ "bolos" ] } diff --git a/ledger_secure_sdk_sys/devices/nanosplus/nanosplus.json b/ledger_secure_sdk_sys/devices/nanosplus/nanosplus.json index f54624b6..4507d7cf 100644 --- a/ledger_secure_sdk_sys/devices/nanosplus/nanosplus.json +++ b/ledger_secure_sdk_sys/devices/nanosplus/nanosplus.json @@ -24,7 +24,7 @@ }, "relocation-model": "ropi-rwpi", "singlethread": true, - "target-pointer-width": "32", + "target-pointer-width": 32, "os": "nanosplus", "target-family": [ "bolos" ] } diff --git a/ledger_secure_sdk_sys/devices/nanox/nanox.json b/ledger_secure_sdk_sys/devices/nanox/nanox.json index ef40927c..63d26d93 100644 --- a/ledger_secure_sdk_sys/devices/nanox/nanox.json +++ b/ledger_secure_sdk_sys/devices/nanox/nanox.json @@ -24,7 +24,7 @@ }, "relocation-model": "ropi-rwpi", "singlethread": true, - "target-pointer-width": "32", + "target-pointer-width": 32, "os": "nanox", "target-family": [ "bolos" ] } diff --git a/ledger_secure_sdk_sys/devices/stax/stax.json b/ledger_secure_sdk_sys/devices/stax/stax.json index c2e93cd0..7192498b 100644 --- a/ledger_secure_sdk_sys/devices/stax/stax.json +++ b/ledger_secure_sdk_sys/devices/stax/stax.json @@ -24,7 +24,7 @@ }, "relocation-model": "ropi-rwpi", "singlethread": true, - "target-pointer-width": "32", + "target-pointer-width": 32, "os": "stax", "target-family": [ "bolos" ] } diff --git a/rust-toolchain.toml b/rust-toolchain.toml index 271800cb..132a2886 100644 --- a/rust-toolchain.toml +++ b/rust-toolchain.toml @@ -1,2 +1,2 @@ [toolchain] -channel = "nightly" \ No newline at end of file +channel = "nightly-2025-10-24" \ No newline at end of file From b5d974b10df1b49582b57fd29b9b4f6f9df1ded0 Mon Sep 17 00:00:00 2001 From: GroM Date: Mon, 1 Dec 2025 16:37:28 +0100 Subject: [PATCH 6/7] test builder with updated nightly --- .github/workflows/check_csdk_build_parameters.yml | 2 +- .github/workflows/ci.yml | 8 ++++---- .github/workflows/doc.yml | 2 +- .github/workflows/reusable_build_all_apps.yml | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/check_csdk_build_parameters.yml b/.github/workflows/check_csdk_build_parameters.yml index 96e187d2..f3f9c4ee 100644 --- a/.github/workflows/check_csdk_build_parameters.yml +++ b/.github/workflows/check_csdk_build_parameters.yml @@ -13,7 +13,7 @@ jobs: check_csdk_build_parameters: runs-on: ubuntu-latest container: - image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder:latest + image: jcaporossi/test-devtools:latest strategy: matrix: target: ["nanox", "nanosplus", "stax", "flex", "apex_p"] diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 599b1701..e4afca87 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,7 +18,7 @@ jobs: name: Run static analysis runs-on: ubuntu-latest container: - image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-dev-tools:latest + image: jcaporossi/test-devtools:latest strategy: matrix: target: ["nanox", "nanosplus", "stax", "flex", "apex_p"] @@ -35,7 +35,7 @@ jobs: name: Check code formatting runs-on: ubuntu-latest container: - image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-dev-tools:latest + image: jcaporossi/test-devtools:latest steps: - name: Clone uses: actions/checkout@v4 @@ -47,7 +47,7 @@ jobs: name: Build SDK runs-on: ubuntu-latest container: - image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-dev-tools:latest + image: jcaporossi/test-devtools:latest strategy: matrix: target: ["nanox", "nanosplus", "stax", "flex", "apex_p"] @@ -66,7 +66,7 @@ jobs: name: Run unit and integration tests runs-on: ubuntu-latest container: - image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-dev-tools:latest + image: jcaporossi/test-devtools:latest strategy: matrix: target: ["nanox", "nanosplus", "stax", "flex", "apex_p"] diff --git a/.github/workflows/doc.yml b/.github/workflows/doc.yml index 60809c62..09f5784c 100644 --- a/.github/workflows/doc.yml +++ b/.github/workflows/doc.yml @@ -20,7 +20,7 @@ jobs: contents: read runs-on: ubuntu-latest container: - image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-dev-tools:latest + image: jcaporossi/test-devtools:latest steps: - name: Clone uses: actions/checkout@v4 diff --git a/.github/workflows/reusable_build_all_apps.yml b/.github/workflows/reusable_build_all_apps.yml index f8fd8db3..39e69b21 100644 --- a/.github/workflows/reusable_build_all_apps.yml +++ b/.github/workflows/reusable_build_all_apps.yml @@ -77,7 +77,7 @@ jobs: include: ${{ fromJSON(needs.retrieve-rust-apps.outputs.rust_apps) }} runs-on: ubuntu-latest container: - image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder:latest + image: jcaporossi/test-devtools:latest steps: - name: Install ledgered run: pip install ledgered --break-system-packages From 4e3f593a0b2a5738d546df395836c4484167f3a3 Mon Sep 17 00:00:00 2001 From: GroM Date: Tue, 2 Dec 2025 09:32:59 +0100 Subject: [PATCH 7/7] run cargo fmt --- ledger_device_sdk/src/libcall/swap.rs | 11 +++++++---- ledger_device_sdk/src/nbgl/nbgl_streaming_review.rs | 9 ++++++--- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/ledger_device_sdk/src/libcall/swap.rs b/ledger_device_sdk/src/libcall/swap.rs index cdfc8168..86bf1a29 100644 --- a/ledger_device_sdk/src/libcall/swap.rs +++ b/ledger_device_sdk/src/libcall/swap.rs @@ -205,7 +205,8 @@ pub fn get_check_address_params< } debug_print("==> GET_REF_ADDRESS\n"); - let (address, address_len) = read_c_string::(params.address_to_check as *const i8); + let (address, address_len) = + read_c_string::(params.address_to_check as *const i8); check_address_params.ref_address = address; check_address_params.ref_address_len = address_len; @@ -340,13 +341,15 @@ pub fn sign_tx_params< } debug_print("==> GET_DESTINATION_ADDRESS\n"); - let (address, address_len) = read_c_string::(params.destination_address as *const i8); + let (address, address_len) = + read_c_string::(params.destination_address as *const i8); create_tx_params.dest_address = address; create_tx_params.dest_address_len = address_len; debug_print("==> GET_DESTINATION_ADDRESS_EXTRA_ID\n"); - let (extra_id, extra_id_len) = - read_c_string::(params.destination_address_extra_id as *const i8); + let (extra_id, extra_id_len) = read_c_string::( + params.destination_address_extra_id as *const i8, + ); create_tx_params.dest_address_extra_id = extra_id; create_tx_params.dest_address_extra_id_len = extra_id_len; diff --git a/ledger_device_sdk/src/nbgl/nbgl_streaming_review.rs b/ledger_device_sdk/src/nbgl/nbgl_streaming_review.rs index 49857cc0..4c2a4d37 100644 --- a/ledger_device_sdk/src/nbgl/nbgl_streaming_review.rs +++ b/ledger_device_sdk/src/nbgl/nbgl_streaming_review.rs @@ -145,10 +145,13 @@ impl NbglStreamingReview { Some(w) => { let warning_details = nbgl_warning_t { predefinedSet: (1u32 << W3C_RISK_DETECTED_WARN), - dAppProvider: w.dapp_provider_name.as_ptr() as *const ::core::ffi::c_char, + dAppProvider: w.dapp_provider_name.as_ptr() + as *const ::core::ffi::c_char, reportUrl: w.report_url.as_ptr() as *const ::core::ffi::c_char, - reportProvider: w.report_provider.as_ptr() as *const ::core::ffi::c_char, - providerMessage: w.provider_message.as_ptr() as *const ::core::ffi::c_char, + reportProvider: w.report_provider.as_ptr() + as *const ::core::ffi::c_char, + providerMessage: w.provider_message.as_ptr() + as *const ::core::ffi::c_char, ..Default::default() }; nbgl_useCaseAdvancedReviewStreamingStart(