Skip to content

Commit 4607bbd

Browse files
committed
Removed some examples. A new method has been added in ExcelWorkbook to write and close the workbook.
1 parent edcad21 commit 4607bbd

File tree

9 files changed

+40
-91
lines changed

9 files changed

+40
-91
lines changed

src/main/java/io/github/mbenincasa/javaexcelutils/model/excel/ExcelWorkbook.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -343,4 +343,9 @@ public Boolean isSheetNull(Integer index) {
343343
public FormulaEvaluator getFormulaEvaluator() {
344344
return this.workbook.getCreationHelper().createFormulaEvaluator();
345345
}
346+
347+
public void writeAndClose(OutputStream outputStream) throws IOException {
348+
this.workbook.write(outputStream);
349+
this.close(outputStream);
350+
}
346351
}

src/main/java/io/github/mbenincasa/javaexcelutils/samples/countAllRowsSample/Main.java

Lines changed: 0 additions & 33 deletions
This file was deleted.

src/main/java/io/github/mbenincasa/javaexcelutils/samples/sheetSample/Main.java

Lines changed: 0 additions & 37 deletions
This file was deleted.

src/main/java/io/github/mbenincasa/javaexcelutils/tools/Converter.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -364,10 +364,9 @@ public static OutputStream objectsToExcelStream(List<ObjectToExcel<?>> objectToE
364364
setAutoSizeColumn(excelSheet, fields, clazz);
365365
}
366366

367+
/* Write and close */
367368
OutputStream outputStream = new ByteArrayOutputStream();
368-
excelWorkbook.getWorkbook().write(outputStream);
369-
370-
excelWorkbook.close();
369+
excelWorkbook.writeAndClose(outputStream);
371370
return outputStream;
372371
}
373372

src/test/java/io/github/mbenincasa/javaexcelutils/TestSuite.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@
44
import org.junit.platform.suite.api.Suite;
55

66
@Suite
7-
@SelectPackages({"io.github.mbenincasa.javaexcelutils.tools", "io.github.mbenincasa.javaexcelutils.model"})
7+
@SelectPackages({"io.github.mbenincasa.javaexcelutils"})
88
public class TestSuite {
99
}

src/test/java/io/github/mbenincasa/javaexcelutils/model/ExcelCellTest.java renamed to src/test/java/io/github/mbenincasa/javaexcelutils/model/excel/ExcelCellTest.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,9 @@
1-
package io.github.mbenincasa.javaexcelutils.model;
1+
package io.github.mbenincasa.javaexcelutils.model.excel;
22

33
import io.github.mbenincasa.javaexcelutils.exceptions.ExtensionNotValidException;
44
import io.github.mbenincasa.javaexcelutils.exceptions.OpenWorkbookException;
55
import io.github.mbenincasa.javaexcelutils.exceptions.ReadValueException;
66
import io.github.mbenincasa.javaexcelutils.exceptions.SheetNotFoundException;
7-
import io.github.mbenincasa.javaexcelutils.model.excel.ExcelCell;
8-
import io.github.mbenincasa.javaexcelutils.model.excel.ExcelRow;
9-
import io.github.mbenincasa.javaexcelutils.model.excel.ExcelSheet;
10-
import io.github.mbenincasa.javaexcelutils.model.excel.ExcelWorkbook;
117
import org.junit.jupiter.api.Assertions;
128
import org.junit.jupiter.api.Test;
139

src/test/java/io/github/mbenincasa/javaexcelutils/model/ExcelRowTest.java renamed to src/test/java/io/github/mbenincasa/javaexcelutils/model/excel/ExcelRowTest.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,8 @@
1-
package io.github.mbenincasa.javaexcelutils.model;
1+
package io.github.mbenincasa.javaexcelutils.model.excel;
22

33
import io.github.mbenincasa.javaexcelutils.exceptions.ExtensionNotValidException;
44
import io.github.mbenincasa.javaexcelutils.exceptions.OpenWorkbookException;
55
import io.github.mbenincasa.javaexcelutils.exceptions.SheetNotFoundException;
6-
import io.github.mbenincasa.javaexcelutils.model.excel.ExcelCell;
7-
import io.github.mbenincasa.javaexcelutils.model.excel.ExcelRow;
8-
import io.github.mbenincasa.javaexcelutils.model.excel.ExcelSheet;
9-
import io.github.mbenincasa.javaexcelutils.model.excel.ExcelWorkbook;
106
import org.junit.jupiter.api.Assertions;
117
import org.junit.jupiter.api.Test;
128

src/test/java/io/github/mbenincasa/javaexcelutils/model/ExcelSheetTest.java renamed to src/test/java/io/github/mbenincasa/javaexcelutils/model/excel/ExcelSheetTest.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
1-
package io.github.mbenincasa.javaexcelutils.model;
1+
package io.github.mbenincasa.javaexcelutils.model.excel;
22

33
import io.github.mbenincasa.javaexcelutils.exceptions.ExtensionNotValidException;
44
import io.github.mbenincasa.javaexcelutils.exceptions.OpenWorkbookException;
55
import io.github.mbenincasa.javaexcelutils.exceptions.SheetNotFoundException;
6-
import io.github.mbenincasa.javaexcelutils.model.excel.ExcelRow;
7-
import io.github.mbenincasa.javaexcelutils.model.excel.ExcelSheet;
8-
import io.github.mbenincasa.javaexcelutils.model.excel.ExcelWorkbook;
96
import org.junit.jupiter.api.Assertions;
107
import org.junit.jupiter.api.Test;
118

src/test/java/io/github/mbenincasa/javaexcelutils/model/ExcelWorkbookTest.java renamed to src/test/java/io/github/mbenincasa/javaexcelutils/model/excel/ExcelWorkbookTest.java

Lines changed: 29 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,39 @@
1-
package io.github.mbenincasa.javaexcelutils.model;
1+
package io.github.mbenincasa.javaexcelutils.model.excel;
22

33
import com.opencsv.CSVReader;
44
import com.opencsv.CSVWriter;
55
import io.github.mbenincasa.javaexcelutils.enums.Extension;
66
import io.github.mbenincasa.javaexcelutils.exceptions.ExtensionNotValidException;
77
import io.github.mbenincasa.javaexcelutils.exceptions.OpenWorkbookException;
88
import io.github.mbenincasa.javaexcelutils.exceptions.SheetNotFoundException;
9-
import io.github.mbenincasa.javaexcelutils.model.excel.ExcelSheet;
10-
import io.github.mbenincasa.javaexcelutils.model.excel.ExcelWorkbook;
9+
import io.github.mbenincasa.javaexcelutils.model.converter.ObjectToExcel;
10+
import io.github.mbenincasa.javaexcelutils.tools.Converter;
11+
import io.github.mbenincasa.javaexcelutils.tools.utils.Address;
12+
import io.github.mbenincasa.javaexcelutils.tools.utils.Person;
1113
import org.apache.commons.io.FilenameUtils;
1214
import org.junit.jupiter.api.Assertions;
15+
import org.junit.jupiter.api.BeforeAll;
1316
import org.junit.jupiter.api.Test;
1417

1518
import java.io.*;
19+
import java.util.ArrayList;
1620
import java.util.List;
21+
import java.util.stream.Stream;
1722

1823
public class ExcelWorkbookTest {
1924

2025
private final File excelFile = new File("./src/test/resources/employee.xlsx");
2126
private final File csvFile = new File("./src/test/resources/employee.csv");
2227

28+
private static final List<Person> persons = new ArrayList<>();
29+
private static final List<Address> addresses = new ArrayList<>();
30+
31+
@BeforeAll
32+
static void beforeAll() {
33+
persons.add(new Person("Rossi", "Mario", 20));
34+
addresses.add(new Address("Milano", "Corso Como, 4"));
35+
}
36+
2337
@Test
2438
void open() throws OpenWorkbookException, ExtensionNotValidException, IOException {
2539
ExcelWorkbook excelWorkbook = ExcelWorkbook.open(excelFile);
@@ -185,4 +199,16 @@ void getFormulaEvaluator() throws OpenWorkbookException, ExtensionNotValidExcept
185199
ExcelWorkbook excelWorkbook = ExcelWorkbook.open(excelFile);
186200
Assertions.assertNotNull(excelWorkbook.getFormulaEvaluator());
187201
}
202+
203+
@Test
204+
void writeAndClose() throws ExtensionNotValidException, IOException {
205+
Stream<Person> personStream = persons.stream();
206+
Stream<Address> addressStream = addresses.stream();
207+
List<ObjectToExcel<?>> list = new ArrayList<>();
208+
list.add(new ObjectToExcel<>("Person", Person.class, personStream));
209+
list.add(new ObjectToExcel<>("Address", Address.class, addressStream));
210+
ByteArrayOutputStream outputStream = (ByteArrayOutputStream) Converter.objectsToExcelStream(list, Extension.XLSX, true);
211+
ExcelWorkbook excelWorkbook = new ExcelWorkbook(Extension.XLSX);
212+
Assertions.assertDoesNotThrow(() -> excelWorkbook.writeAndClose(outputStream));
213+
}
188214
}

0 commit comments

Comments
 (0)