Merge pull request #81 from MacPaw/develop

Release

Author: Yozhef

src/Check/RedisCheck.php

@@ -4,24 +4,28 @@
 
 namespace SymfonyHealthCheckBundle\Check;
 
-use SymfonyHealthCheckBundle\Dto\Response;
 use SymfonyHealthCheckBundle\Adapter\RedisAdapterWrapper;
+use SymfonyHealthCheckBundle\Dto\Response;
 
 class RedisCheck implements CheckInterface
 {
     private const CHECK_RESULT_NAME = 'redis_check';
 
     private RedisAdapterWrapper $redisAdapter;
-    private string $redisDsn;
+    private ?string $redisDsn;
 
-    public function __construct(RedisAdapterWrapper $redisAdapter, string $redisDsn)
+    public function __construct(RedisAdapterWrapper $redisAdapter, ?string $redisDsn)
     {
         $this->redisAdapter = $redisAdapter;
         $this->redisDsn = $redisDsn;
     }
 
     public function check(): Response
     {
+        if (empty($this->redisDsn)) {
+            return new Response(self::CHECK_RESULT_NAME, false, 'Invalid redis dsn definition.');
+        }
+
         try {
             $redisConnection = $this->redisAdapter->createConnection($this->redisDsn);
 

tests/Unit/Check/RedisCheckTest.php

@@ -209,6 +209,35 @@ public function testItFailsCheckWithRedisArrayClient(): void
         self::assertIsArray($result['params']);
     }
 
+    public function testItFailsCheckWhenNoRedisDsnProvided(): void
+    {
+        $adapter = $this->createMock(RedisAdapterWrapper::class);
+
+        /** @var \Redis $connectionMock */
+        $connectionMock = $this->createMock(\Redis::class);
+
+        $adapter
+            ->method('createConnection')
+            ->willReturn($connectionMock);
+
+        $check = new RedisCheck($adapter, null);
+
+        $result = $check->check()->toArray();
+
+        self::assertIsArray($result);
+        self::assertNotEmpty($result);
+
+        self::assertArrayHasKey('name', $result);
+        self::assertArrayHasKey('result', $result);
+        self::assertArrayHasKey('message', $result);
+        self::assertArrayHasKey('params', $result);
+
+        self::assertSame('redis_check', $result['name']);
+        self::assertFalse($result['result']);
+        self::assertSame('Invalid redis dsn definition.', $result['message']);
+        self::assertIsArray($result['params']);
+    }
+
     /**
      * @param string|bool $response
      *